-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thread safe DataFormats/DTRecHit #1304
Thread safe DataFormats/DTRecHit #1304
Conversation
Although the const_cast was not needed, it was showing up as a warning by the thread-safety checker.
Previously, the function local statics were not declared const because there was no way to easily set their values via the constructor. This code was changed to use 'const function statics' where we use a helper function to do the setup. This avoids thread-safety issues.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X. Thread safe DataFormats/DTRecHit It involves the following packages: DataFormats/DTRecHit @nclopezo, @thspeer, @slava77 can you please review it and eventually sign? Thanks. |
+1 tested in CMSSW_7_0_X_2013-11-05-1400 as sign269
all merge, compile, and run OK and there are no differences in outputs, as expected |
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
Multithreading fixes -- Thread safe DataFormats/DTRecHit
Fixed thread safety issues (non-const statics and const_cast) find by the static analyzer.