Fix thread safety issues by removing mutable data members of MuonDetIdAssociator #1347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class MuonDetIdAssociator contained two mutable data members, both vectors, that were modified by const member functions of the class. This is not thread safe.
This pull request removes the mutable data members. Instead, a vector is passed in to the functions for filling by the functions. There is no need to store the vectors in the class.
Tested with checkdeps -a and the relval matrix.