Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Stage-1 L1 HI ETT algorithm #13048

Merged

Conversation

harmonicoscillator
Copy link
Contributor

(cherry picked from commit 59ae76a)

These values are not changeable online. O2O code for HI does not set a default, so previous results were garbage. Boundaries of 4 and 17 correspond to all non-HF regions.

This algorithm is not actually used by any HIN physics group, but this fix should save someone in the future who might want to to ETT with HI Stage 1 triggers.

(cherry picked from commit 59ae76a)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_8_0_X.

It involves the following packages:

L1Trigger/L1TCalorimeter

@cmsbuild, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mulhearn
Copy link
Contributor

please test

@mulhearn
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10707/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Jan 25, 2016
@cmsbuild cmsbuild merged commit 4e76e13 into cms-sw:CMSSW_8_0_X Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants