Hit pair implementation #13051

a-kapoor · 2016-01-25T12:01:31Z

Changes expected after the pull request are explained in this presentation:
FullSimVsFastSim_IterationComparison_Debugging_Tracking_POG_Meeting_18Jan16.pdf
Hit pair check for seed implemented.

cmsbuild · 2016-01-25T12:01:52Z

A new Pull Request was created by @Ansh0712 (Anshul Kapoor) for CMSSW_8_0_X.

It involves the following packages:

FastSimulation/Tracking
RecoTracker/TkHitPairs

@civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @mschrode, @matt-komm, @gpetruc, @istaslis, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

VinInn · 2016-01-25T13:07:12Z

from a visual inspection the reco part looks purely technical.
Should not produce neither regression nor timing issues.

slava77 · 2016-01-25T13:24:18Z

FastSimulation/Tracking/plugins/TrajectorySeedProducer.h

@@ -43,7 +43,7 @@ class TrajectorySeedProducer:
        const MagneticFieldMap* magneticFieldMap;
        const TrackerGeometry* trackerGeometry;
        const TrackerTopology* trackerTopology;
-
+	//const RecHitsSortedInPhi * ih;


here and in other modified files, please cleanup the commented out code, unless there is a good reason to keep it.

slava77 · 2016-01-26T15:05:11Z

@Ansh0712 please clarify when should we expect updates to this PR.
Thank you.

a-kapoor · 2016-01-26T15:11:49Z

In a couple of hours.

-----Original Message-----
From: "Slava Krutelyov" notifications@github.com
Sent: ‎26/‎01/‎2016 20:35
To: "cms-sw/cmssw" cmssw@noreply.github.com
Cc: "Anshul Kapoor" anshul.kapoor@students.iiserpune.ac.in
Subject: Re: [cmssw] Hit pair implementation (#13051)

@Ansh0712 please clarify when should we expect updates to this PR.
Thank you.
—
Reply to this email directly or view it on GitHub.

cmsbuild · 2016-01-26T20:25:53Z

Pull request #13051 was updated. @civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

cmsbuild · 2016-01-26T20:26:38Z

Pull request #13051 was updated. @civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

slava77 · 2016-01-26T21:14:10Z

RecoTracker/TkHitPairs/src/HitPairGeneratorFromLayerPair.cc

@@ -167,5 +182,8 @@ HitDoublets HitPairGeneratorFromLayerPair::doublets( const TrackingRegion& regio
  }
  LogDebug("HitPairGeneratorFromLayerPair")<<" total number of pairs provided back: "<<result.size();
  result.shrink_to_fit();
-  return result;
+  //return result;


not needed?

Thanks for pointing out. Ya it is not needed.

cmsbuild · 2016-01-27T08:28:53Z

Pull request #13051 was updated. @civanch, @lveldere, @cvuosalo, @ssekmen, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

a-kapoor · 2016-01-27T08:58:25Z

please test

Few lines got deleted erroneously.

slava77 · 2016-01-27T13:15:12Z

@cmsbuild please test

cmsbuild · 2016-01-27T13:15:31Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10774/console

cmsbuild · 2016-01-27T15:34:16Z

+1
Tested at: ca049df
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13051/10774/summary.html

cmsbuild · 2016-01-27T16:27:54Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13051/10774/summary.html

lveldere · 2016-01-27T16:36:20Z

+1

slava77 · 2016-01-28T04:56:04Z

+1

for #13051 ca049df

code changes are in line with the description; expected to change only behavior in fastsim
jenkins tests pass and comparisons with baseline show differences only in fastsim workflows (posted earlier for a previous commit .. there were no functional changes since then a-kapoor/cmssw@d960f57...ca049df
)

cmsbuild · 2016-01-28T06:33:41Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 · 2016-01-28T12:33:40Z

+1

Hit pair implementation

a-kapoor added 3 commits January 8, 2016 10:30

Interface of standard hit pairs check in TrajectorySeedProducer

fd7a441

Typo fixed

3238666

Fixed a crash: Seed Creator was not initialized

9ddb718

cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 25, 2016

cmsbuild added reconstruction-pending fastsim-pending pending-signatures tests-pending orp-pending comparison-pending labels Jan 25, 2016

Update TrajectorySeedProducer.cc

84e4b99

slava77 reviewed Jan 25, 2016
View reviewed changes

a-kapoor added 4 commits January 27, 2016 01:55

Update TrajectorySeedProducer.h

4b47285

Update HitPairGeneratorFromLayerPair.cc

0d8507b

Update HitPairGeneratorFromLayerPair.h

349668c

Update TrajectorySeedProducer.cc

1ae86bf

Update HitPairGeneratorFromLayerPair.cc

efd78dd

slava77 reviewed Jan 26, 2016
View reviewed changes

Update TrajectorySeedProducer.cc

ca049df

cmsbuild added tests-pending and removed tests-rejected labels Jan 27, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 27, 2016

cmsbuild added tests-approved and removed tests-started labels Jan 27, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 27, 2016

cmsbuild added fastsim-approved and removed fastsim-pending labels Jan 27, 2016

cmsbuild added reconstruction-approved fully-signed and removed pending-signatures reconstruction-pending labels Jan 28, 2016

cmsbuild added orp-approved and removed orp-pending labels Jan 28, 2016

cmsbuild added a commit that referenced this pull request Jan 28, 2016

Merge pull request #13051 from ANSH0712/hitPairImplementation

9531693

Hit pair implementation

cmsbuild merged commit 9531693 into cms-sw:CMSSW_8_0_X Jan 28, 2016

cmsbuild added a commit that referenced this pull request Jan 28, 2016

Merge pull request #13051 from ANSH0712/hitPairImplementation

dc63b19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hit pair implementation #13051

Hit pair implementation #13051

a-kapoor commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

VinInn commented Jan 25, 2016

slava77 Jan 25, 2016

a-kapoor Jan 26, 2016

slava77 commented Jan 26, 2016

a-kapoor commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

slava77 Jan 26, 2016

a-kapoor Jan 26, 2016

cmsbuild commented Jan 27, 2016

a-kapoor commented Jan 27, 2016

slava77 commented Jan 27, 2016

cmsbuild commented Jan 27, 2016

cmsbuild commented Jan 27, 2016

cmsbuild commented Jan 27, 2016

lveldere commented Jan 27, 2016

slava77 commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

davidlange6 commented Jan 28, 2016

Hit pair implementation #13051

Hit pair implementation #13051

Conversation

a-kapoor commented Jan 25, 2016

cmsbuild commented Jan 25, 2016

VinInn commented Jan 25, 2016

slava77 Jan 25, 2016

Choose a reason for hiding this comment

a-kapoor Jan 26, 2016

Choose a reason for hiding this comment

slava77 commented Jan 26, 2016

a-kapoor commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

cmsbuild commented Jan 26, 2016

slava77 Jan 26, 2016

Choose a reason for hiding this comment

a-kapoor Jan 26, 2016

Choose a reason for hiding this comment

cmsbuild commented Jan 27, 2016

a-kapoor commented Jan 27, 2016

slava77 commented Jan 27, 2016

cmsbuild commented Jan 27, 2016

cmsbuild commented Jan 27, 2016

cmsbuild commented Jan 27, 2016

lveldere commented Jan 27, 2016

slava77 commented Jan 28, 2016

cmsbuild commented Jan 28, 2016

davidlange6 commented Jan 28, 2016