Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the correct classes.h path (no duplicate src/src) #13052

Merged
merged 1 commit into from Jan 25, 2016
Merged

use the correct classes.h path (no duplicate src/src) #13052

merged 1 commit into from Jan 25, 2016

Conversation

smuzaffar
Copy link
Contributor

This should avoid the following error messages which running ib-static-tests i.e. src/src used twice

+ ./run_class_dumper.sh 8
./run_class_dumper.sh: line 8: rel-path/src/src/SimDataFormats/DigiSimLinks/src/classes.h.cc: No such file or directory

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_8_0_X.

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@smuzaffar
Copy link
Contributor Author

please test
though there is nothing in jenkins PR test which is going to use it

@smuzaffar
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10717/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@smuzaffar
Copy link
Contributor Author

merge
this is only used in IBs clang static test, so I am approving it

cmsbuild added a commit that referenced this pull request Jan 25, 2016
use the correct classes.h path (no duplicate src/src)
@cmsbuild cmsbuild merged commit a19a704 into cms-sw:CMSSW_8_0_X Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants