Fixing HGCal Hexagonal Geometry Round 2 #13069
Conversation
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_8_0_X. It involves the following packages: Geometry/HGCalCommonData @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
-1 Tested at: 7db5e39 cmsDriver.py RelVal -s L1REPACK:GT2 --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Tue Jan 26 11:21:03 2016-date Tue Jan 26 11:20:11 2016 s - exit: 23552 you can see the results of the tests here: |
|
@cmsbuild - it does not look like the errors are related to this PR |
|
@slava77 is this error fixed in another PR? (or the next IB?) |
|
@cmsbuild please test add on tests in the baseline IB look OK https://cmssdt.cern.ch/SDT/cgi-bin//showAddOnLogs.py/slc6_amd64_gcc493/www/mon/8.0-mon-23/CMSSW_8_0_X_2016-01-25-2300/addOnTests/ |
|
The tests are being triggered in jenkins. |
cmsbuild
added
tests-pending
comparison-pending
tests-started
and removed
comparison-available
tests-rejected
tests-pending
labels
|
-1 Tested at: 7db5e39 cmsDriver.py RelVal -s L1REPACK:GT2 --data --scenario=HeavyIons -n 10 --conditions auto:run2_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_HI --magField 38T_PostLS1 --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/hidata/HIRun2015/HIHardProbes/RAW-RECO/HighPtJet-PromptReco-v1/000/263/689/00000/1802CD9A-DDB8-E511-9CF9-02163E0138CA.root : FAILED - time: date Tue Jan 26 21:23:39 2016-date Tue Jan 26 21:22:56 2016 s - exit: 23552 you can see the results of the tests here: |
|
Pull request #13069 was updated. @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please check and sign again. |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
Please begin review. Do not plan to add anything else. |
|
+1 |
|
+1 |
cmsbuild
added
simulation-approved
fully-signed
and removed
pending-signatures
simulation-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
@davidlange6 Would appreciate if this one is in the IBs next week as well. Just making sure it didn't slip past you. |
|
+1 |
Fixing HGCal Hexagonal Geometry Round 2
Continuation of #13038.
This PR fixes a hex wafer numbering bug arising from having used a map to store a list of wafer copy numbers. This meant that wafer indices did not contiguously span a given layer, and that property was assumed elsewhere in the code. This led to numerous out-of-bounds det ids in certain regions of the HGCal.
Part two of the fix was then to realize that "contiguous set of det ids" is not well defined in this geometry since the inner and outer radii are changing in the layers. The valid det ids in each layer are now indexed by a hash map.
The out-of-bounds detids no longer appear even in large samples, but there are a few cases where the sim and reco geometries do not map to each other correctly. That will come in another round of fixes.
@bsunanda