SiStrip Calibration common framework revamp #13101
Conversation
…ning on PCL and CalibTree
|
A new Pull Request was created by @mverzett (Mauro Verzetti) for CMSSW_8_0_X. It involves the following packages: CalibTracker/SiStripChannelGain @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
@mverzett about the request for addition of the unit tests I suggest you open an issue in the cmssw project |
|
Hi @mverzett , could you please make a better description in the title, 'New strip sw' is not very explicit . |
|
hi @mverzett , thanks a lot, that's perfect |
| @@ -22,7 +25,7 @@ produce(edm::Event& iEvent, const edm::EventSetup& iSetup) { | |||
|
|
|||
|
|
|||
| edm::Handle< L1GlobalTriggerReadoutRecord > gtRecord; | |||
| iEvent.getByLabel( edm::InputTag("gtDigis"), gtRecord); | |||
| iEvent.getByToken(trig_token_, gtRecord); | |||
There was a problem hiding this comment.
@davidlange6 change made. Thanks for spotting it!
|
The last change was to comply with @davidlange6 comment to use the token system in one module in which was missing. |
|
-1 DAS Error you can see the results of the tests here: |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
comparison-available
and removed
alca-pending
comparison-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
+1 |
SiStrip Calibration common framework revamp
This PR revamps the SiStrip Calibration common framework. It also slightly changes the ALCARECO workflow to be more DRY and have overlapping code for PCL and standalone calibration workflows.
I also added several unit tests to check in the IBs whether some upstream code changes may break our code and act promptly. Would it be possible to add this script to the jenkins stack?
Interested people: @dimattia @jlagram