Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70X consumes migration III #1311

Merged
merged 2 commits into from Nov 8, 2013
Merged

Conversation

vadler
Copy link

@vadler vadler commented Nov 4, 2013

Migration of PFBRECO to 'consumes'/'getByToken'-API.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2013

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_7_0_X.

70X consumes migration III

It involves the following packages:

PhysicsTools/HepMCCandAlgos
CommonTools/CandAlgos
PhysicsTools/CandAlgos
CommonTools/ParticleFlow
CommonTools/RecoAlgos
PhysicsTools/IsolationAlgos
CommonTools/UtilAlgos

@nclopezo, @vadler, @thspeer, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@vadler
Copy link
Author

vadler commented Nov 4, 2013

+1

@nclopezo
Copy link
Contributor

nclopezo commented Nov 5, 2013

@slava77
Copy link
Contributor

slava77 commented Nov 7, 2013

@slava77 working on it

@vadler
Copy link
Author

vadler commented Nov 7, 2013

@slava77 FYI:
The remaining "getByLabels" in CommonTools/ParticleFlow are worked on separately, since it needs more time to find through those selectors' template jungle -- and back.

@slava77
Copy link
Contributor

slava77 commented Nov 8, 2013

+1

tested in CMSSW_7_0_X_2013-11-05-1400 (sign270) in a combination of

no differences as expected

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 8, 2013
@ktf ktf merged commit 6b936cc into cms-sw:CMSSW_7_0_X Nov 8, 2013
@vadler vadler deleted the 70X-consumesMigration-III branch November 8, 2013 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants