C++11 modernization for FWLite

[wmtan]

This PR upgrades the FWLite code to C++11/C++14 standards.
This includes:

1. replacing auto_ptr with unique_ptr
2. using make_shared and make_unique where appropriate
3. Replacing 0 with nullptr where applicable
4. changing iterator loops to range based for loops where appropriate.
5. using the auto keyword in for loops.
   Also, the const qualifier was added to some for loops where it was missing.
   Some of these changes are prerequisites for implementing propagate_const in FWLite code,
   which will be done in subsequent PR's.

[cmsbuild]

A new Pull Request was created by @wmtan for CMSSW_8_0_X.

It involves the following packages:

DataFormats/FWLite
FWCore/FWLite
FWCore/TFWLiteSelector
FWCore/TFWLiteSelectorTest

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[davidlange6]

@wmtan - this does not merge

[wmtan]

@davidlange6 OK, I will rebase it.

[cmsbuild]

Pull request #13118 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

[wmtan]

@davidlange6 Rebased. Should merge now.

[davidlange6]

please test

On Jan 29, 2016, at 4:51 PM, wmtan notifications@github.com wrote:

@davidlange6 Rebased. Should merge now.

—
Reply to this email directly or view it on GitHub.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10847/console

[cmsbuild]

-1

Tested at: 9645ab0
I found errors in the following unit tests:

---> test testRecoMETMETProducers had ERRORS
---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS
---> test runtestSimCalorimetryHGCalSimProducers had ERRORS
---> test DetectorDescriptionRegressionTestDOMCount had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13118/10847/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d120b1d
81a912b
471f6c6
5bc0097
dd3d2c4
4d57087
227e959
a11d0ac
40bea38
c057e65
3e850ff
840efb4
c0ebb2a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13118/10847/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13118/10847/git-merge-result

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13118/10847/summary.html

[cmsbuild]

Pull request #13118 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please check and sign again.

[wmtan]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10857/console

[cmsbuild]

+1
Tested at: fe51df1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13118/10857/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13118/10857/summary.html

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1