Cleanup of dependencies from CondDBv1 code #13131

ggovi · 2016-01-29T21:33:10Z

The changes of PR #13108 have been re-built in a new branch cherry-picking the commits from the original branch and applying them on the last IB:

Clean up from CondDBv1: removed dependencies from packages: CondCore/DBCommon, CondCore/ORA, CondCore/MetaDataService, CondCore/TagCollection, in particular in Configuration/StandardSequences/python/FrontierConditions_GlobalTag_cfi.py used by cmsDriver to set up condition access.
Added TagLog functionality
Added the possibility to configure Frontier connection in order to request the server sends digital signatures on every response. This is done by setting a string data member in ConnectionPool or the corresponding parameter in a ParameterSet. An unit test has been added. The default is "", so the current behaviour is kept.

…ameter is set to sig, FroNTier requests that the server sends digital signatures on every response. Add frontier security option as a string data member in ConnectionPool, and define appropriate setter. The frontier security option is turned on for all sessions using the same ConnectionPool for configuring the server access via CORAL. Add FroNTier security option in DBParameters PSet of CondDB setup. Put a default value for the authentication path in ConnectionPool. When setting connection parameters from a ParameterSet in ConnectionPool, if a parameter is not defined, keep the values already set in the data members (i.e. default if no other setters called, or the ones currently available). Removed duplicated code for setting table time to live parameters of Condition schema in ConnectionPool. Removed the unused dbFormat parameter in CondDB_cfi.py as we only support CondDBv2, and dropped unused CondDBboost_cfi. New unit test for ConnectionPool. Add a warning about unsupported connection strings. Conflicts: CondCore/CondDB/src/ConnectionPool.cc CondCore/CondDB/src/DbConnectionString.cc

…DBSetup for CondDBv1.

* Added RelationalAuthenticationService and XMLAuthenticationService plugins in CondCore/CondDB * Use the newly defined auth namespace in CondDB * Add missing dependencies in plugins BuildFile of CondDB * Fix for one DBCommon left over * Fix for non-required dependencies

…n_cfi.py and CondCore/DBCommon/python/CondDBSetup_cfi.py deprecated ( a message is printed out ) and point to CondCore/CondDB/python/CondDB_cfi.py.

…ervlets for fetching Condition payloads in CondCore/ESSources/python/CondDBESSource_cfi.py. This is then loaded in Configuration/StandardSequences/python/FrontierConditions_GlobalTag_cfi.py and cloned in RecoTauTag/Configuration/python/loadRecoTauTagMVAsFromPrepDB_cfi.py.

cmsbuild · 2016-01-29T21:33:40Z

A new Pull Request was created by @ggovi for CMSSW_8_0_X.

It involves the following packages:

Alignment/CocoaApplication
Alignment/CocoaFit
Alignment/CommonAlignmentAlgorithm
Alignment/MuonAlignment
CalibCalorimetry/CaloMiscalibTools
CalibCalorimetry/EcalCorrelatedNoiseAnalysisModules
CalibCalorimetry/EcalTPGTools
CalibMuon/CSCCalibration
CalibTracker/SiPixelConnectivity
CalibTracker/SiStripDCS
CalibTracker/SiStripESProducers
CommonTools/ConditionDBWriter
CondCore/BeamSpotPlugins
CondCore/CondDB
CondCore/DBCommon
CondCore/DBOutputService
CondCore/ESSources
CondCore/EgammaPlugins
CondCore/HIPlugins
CondCore/MetaDataService
CondCore/ORA
CondCore/PopCon
CondCore/RecoMuonPlugins
CondCore/TagCollection
CondCore/Utilities
CondFormats/Common
CondFormats/DTObjects
CondFormats/EcalObjects
CondFormats/MFObjects
CondFormats/PhysicsToolsObjects
CondTools/DT
CondTools/Ecal
CondTools/Hcal
CondTools/L1Trigger

@diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @apfeiffer1, @battibass, @abbiendi, @gbenelli, @tocheng, @argiro, @jlagram, @dkotlins, @jhgoh, @tlampen, @mschrode, @mmusich, @trocino this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

ggovi · 2016-01-29T21:35:14Z

please test

cmsbuild · 2016-01-29T21:35:43Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10852/console

cmsbuild · 2016-01-30T02:30:53Z

-1

Tested at: c77265e
I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS
---> test runtestSimCalorimetryHGCalSimProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13131/10852/summary.html

cmsbuild · 2016-01-30T03:14:03Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13131/10852/summary.html

ggovi · 2016-01-30T12:41:41Z

please test

cmsbuild · 2016-01-30T12:42:08Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10858/console

diguida · 2016-01-30T20:36:45Z

@ggovi the fix is diguida@61fbbe4

…on/loadRecoTauTagMVAsFromPrepDB_cfi.py, not importing nor cloning from default definition, in order to avoid ESSource conflicts when defining PAT sequences. This is a workaround, not a fix.

cmsbuild · 2016-01-30T21:38:19Z

Pull request #13131 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich, @mulhearn, @davidlange6 can you please check and sign again.

ggovi · 2016-01-30T21:39:42Z

please test

cmsbuild · 2016-01-30T21:40:12Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10860/console

cmsbuild · 2016-01-31T01:21:09Z

+1
Tested at: 6b8c2ab
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13131/10860/summary.html

cmsbuild · 2016-01-31T02:11:41Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13131/10860/summary.html

ggovi · 2016-01-31T10:04:53Z

+1

ggovi · 2016-01-31T10:06:19Z

@mmusich @franzoni @mulhearn
same changes as before, re-packaged in a new PR... please take action

mmusich · 2016-02-01T09:44:30Z

+1

ggovi · 2016-02-01T14:05:34Z

@mulhearn
Could you please take action?

davidlange6 · 2016-02-01T15:39:04Z

lets hope that the 3rd time is the charm...

Cleanup of dependencies from CondDBv1 code

ggovi and others added 7 commits January 29, 2016 15:54

Removed CondCore/DBCommon dependencies

def3b4a

Added TagLog feature

994e759

Cleanup: use CondDB ParameterSet defined for CondDBv2 instead of Cond…

fc4cbe8

…DBSetup for CondDBv1.

Backward compatibility fix: make CondCore/DBCommon/python/CondDBCommo…

9737ee2

…n_cfi.py and CondCore/DBCommon/python/CondDBSetup_cfi.py deprecated ( a message is printed out ) and point to CondCore/CondDB/python/CondDB_cfi.py.

cmsbuild added this to the Next CMSSW_8_0_X milestone Jan 29, 2016

cmsbuild added l1-pending alca-pending db-pending pending-signatures tests-pending orp-pending comparison-pending labels Jan 29, 2016

ggovi mentioned this pull request Jan 29, 2016

Cleanup of dependencies from CondDBv1 code #13108

Closed

cmsbuild added tests-started and removed tests-pending labels Jan 29, 2016

cmsbuild added tests-rejected and removed tests-started labels Jan 30, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 30, 2016

cmsbuild removed the comparison-available label Jan 30, 2016

cmsbuild added the comparison-available label Jan 30, 2016

Initialise a PoolDBESSource instance in RecoTauTag/Configuration/pyth…

6b8c2ab

…on/loadRecoTauTagMVAsFromPrepDB_cfi.py, not importing nor cloning from default definition, in order to avoid ESSource conflicts when defining PAT sequences. This is a workaround, not a fix.

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-rejected labels Jan 30, 2016

cmsbuild added tests-started and removed tests-pending labels Jan 30, 2016

cmsbuild added tests-approved and removed tests-started labels Jan 31, 2016

cmsbuild added comparison-available and removed comparison-pending labels Jan 31, 2016

cmsbuild added db-approved and removed db-pending labels Jan 31, 2016

cmsbuild added alca-approved and removed alca-pending labels Feb 1, 2016

davidlange6 added a commit that referenced this pull request Feb 1, 2016

Merge pull request #13131 from ggovi/conddbV2-remove-V1-deps-5

fa6068b

Cleanup of dependencies from CondDBv1 code

davidlange6 merged commit fa6068b into cms-sw:CMSSW_8_0_X Feb 1, 2016

cmsbuild added a commit that referenced this pull request Feb 1, 2016

Merge pull request #13131 from ggovi/conddbV2-remove-V1-deps-5

8a0b437

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cleanup of dependencies from CondDBv1 code #13131

Cleanup of dependencies from CondDBv1 code #13131

ggovi commented Jan 29, 2016

cmsbuild commented Jan 29, 2016

ggovi commented Jan 29, 2016

cmsbuild commented Jan 29, 2016

cmsbuild commented Jan 30, 2016

cmsbuild commented Jan 30, 2016

ggovi commented Jan 30, 2016

cmsbuild commented Jan 30, 2016

diguida commented Jan 30, 2016

cmsbuild commented Jan 30, 2016

ggovi commented Jan 30, 2016

cmsbuild commented Jan 30, 2016

cmsbuild commented Jan 31, 2016

cmsbuild commented Jan 31, 2016

ggovi commented Jan 31, 2016

ggovi commented Jan 31, 2016

mmusich commented Feb 1, 2016

ggovi commented Feb 1, 2016

davidlange6 commented Feb 1, 2016

Cleanup of dependencies from CondDBv1 code #13131

Cleanup of dependencies from CondDBv1 code #13131

Conversation

ggovi commented Jan 29, 2016

cmsbuild commented Jan 29, 2016

ggovi commented Jan 29, 2016

cmsbuild commented Jan 29, 2016

cmsbuild commented Jan 30, 2016

cmsbuild commented Jan 30, 2016

ggovi commented Jan 30, 2016

cmsbuild commented Jan 30, 2016

diguida commented Jan 30, 2016

cmsbuild commented Jan 30, 2016

ggovi commented Jan 30, 2016

cmsbuild commented Jan 30, 2016

cmsbuild commented Jan 31, 2016

cmsbuild commented Jan 31, 2016

ggovi commented Jan 31, 2016

ggovi commented Jan 31, 2016

mmusich commented Feb 1, 2016

ggovi commented Feb 1, 2016

davidlange6 commented Feb 1, 2016