New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow a modification to depend on multiple Modifiers #13132
Allow a modification to depend on multiple Modifiers #13132
Conversation
Allow a configuration modification to only be applied if multiple Modifiers have been chosen. This is done using the '&' operator to join all the required Modifiers.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X. It involves the following packages: FWCore/ParameterSet @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
-1 Tested at: 544dc71 ---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS you can see the results of the tests here: The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
The unit tests failures were not caused by this pull request. Even the one from FWCore/ParameterSet is from a FileInPath failure which could not be caused by this change. |
Allow a modification to depend on multiple Modifiers
Allow a configuration modification to only be applied if multiple Modifiers have been chosen. This is done using the '&' operator to join all the required Modifiers.