Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a modification to depend on multiple Modifiers #13132

Merged

Conversation

Dr15Jones
Copy link
Contributor

Allow a configuration modification to only be applied if multiple Modifiers have been chosen. This is done using the '&' operator to join all the required Modifiers.

Allow a configuration modification to only be applied if multiple Modifiers have been chosen. This is done using the '&' operator to join all the required Modifiers.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_8_0_X.

It involves the following packages:

FWCore/ParameterSet

@cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10853/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

-1

Tested at: 544dc71
I found errors in the following unit tests:

---> test runtestRecoLocalCaloHGCalRecProducers had ERRORS
---> test testRecoMETMETProducers had ERRORS
---> test testPythonParameterSet had ERRORS
---> test DetectorDescriptionRegressionTestDOMCount had ERRORS
---> test runtestSimCalorimetryHGCalSimProducers had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13132/10853/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
81a912b
471f6c6
5bc0097
dd3d2c4
4d57087
227e959
a11d0ac
40bea38
c057e65
3e850ff
840efb4
c0ebb2a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13132/10853/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13132/10853/git-merge-result

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor Author

The unit tests failures were not caused by this pull request. Even the one from FWCore/ParameterSet is from a FileInPath failure which could not be caused by this change.

davidlange6 added a commit that referenced this pull request Jan 31, 2016
Allow a modification to depend on multiple Modifiers
@davidlange6 davidlange6 merged commit a7e19cf into cms-sw:CMSSW_8_0_X Jan 31, 2016
@Dr15Jones Dr15Jones deleted the canRequireMultipleModifiers branch February 4, 2016 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants