Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppi tuning for80x #13136

Merged
merged 3 commits into from Feb 2, 2016
Merged

Puppi tuning for80x #13136

merged 3 commits into from Feb 2, 2016

Conversation

hsatoshi
Copy link
Contributor

Puppi is tuned for 80x release with new samples.
A work with @nhanvtran and @violatingcp.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hsatoshi for CMSSW_8_0_X.

It involves the following packages:

CommonTools/PileupAlgos

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Jan 31, 2016

@hsatoshi please provide some details on changes in physics performance
(puppijets, isolation etc).
I suppose, this work was presented in a JME meeting.
If so, please add a link in the PR description block (edit your original "Puppi is tuned for 80x ...")

Thank you.

@slava77
Copy link
Contributor

slava77 commented Jan 31, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10862/console

@cmsbuild
Copy link
Contributor

-1
Tested at: c680e86
When I ran the RelVals I found an error in the following worklfows:
8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13136/10862/summary.html

@slava77
Copy link
Contributor

slava77 commented Jan 31, 2016

@cmsbuild please test
(the errors seemed unrelated)

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10866/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@hsatoshi
Copy link
Contributor Author

hsatoshi commented Feb 1, 2016

(for the record ; I sent an email to Jim and Andreas for a brief explanation of the update)

@slava77
Copy link
Contributor

slava77 commented Feb 1, 2016

@jdolen @ahinzmann
based on the email exchanges with plots, please clarify if the updates look good to you from the point of view of physics performance.
We can probably wait until Feb 3 meeting to get feedback before integrating this PR, but it will be pushing it against the deadline.

@ahinzmann
Copy link
Contributor

@slava77 the updates look good. please go ahead with the integration!

@slava77
Copy link
Contributor

slava77 commented Feb 2, 2016

+1

for #13136 c680e86

  • changes in the configuration reduce thresholds on neutrals in the forward region and slightly increase it in the eta<2.5 region. The reduced thresholds in the forward reflects improved performance of the HF in 76X/80X. More details will be presented in JME working meeting on Feb 3 ( @hsatoshi please add a link to the slides in this PR after the meeting happens)
  • jenkins tests pass and comparisons with baseline show differences only in puppi-related objects (jets and MET)
    • there is a clear increase in HF contribution (all plots are from SinglePh 2015D workflow 134.911)
      wf134 911_puppijetscleaned_eta
      wf134 911_puppijetscleaned_nconst_fwd
      wf134 911_puppimetcleaned_hfemetvsnvtx
      wf134 911_puppimetcleaned_hfhadetvsnvtx
  • local test on 70 ttbar events from 25202 running PAT step only shows no significant change in CPU and event size comparison shows rather small changes in puppi-related objects
   or, B         new, B      delta, B   delta, %   deltaJ, %    branch 
-----------------------------------------------------------------
   2529.5 ->      2543.3         14      0.5   0.02     patJets_slimmedJetsPuppi__DQM.
    895.9 ->       897.6          2      0.2   0.00     patMETs_slimmedMETsPuppi__DQM.
  19207.0 ->     19240.7         34      0.2   0.05     patPackedCandidates_packedPFCandidates__DQM.
-------------------------------------------------------------
    74520 ->       74569         49             0.1     ALL BRANCHES

davidlange6 added a commit that referenced this pull request Feb 2, 2016
@davidlange6 davidlange6 merged commit 010500c into cms-sw:CMSSW_8_0_X Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants