Classes in DataFormats/L1DTTrackFinder only return const * from const functions #1314
Conversation
… functions. The thread-safety checker complained that the Container classes in DataFormats/L1DTTrackFinder were returning non-const pointers to member data from const member functions. These were changed to return const pointers. This required changing variable types in calling classes however it turned out those classes never modified the objects anyway so no algorithmic changes were neeed.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_0_X. Classes in DataFormats/L1DTTrackFinder only return const * from const functions It involves the following packages: L1Trigger/HardwareValidation @perrotta, @nclopezo, @danduggan, @rovere, @Martin-Grunewald, @deguio, @fwyzard, @eliasron, @mulhearn can you please review it and eventually sign? Thanks. |
|
+1 |
2 similar comments
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it? |
…TTrackFinder Multithreading fixes -- Classes in DataFormats/L1DTTrackFinder only return const * from const functions
The thread-safety checker complained that the Container classes in DataFormats/L1DTTrackFinder
were returning non-const pointers to member data from const member functions. These were
changed to return const pointers. This required changing variable types in calling classes
however it turned out those classes never modified the objects anyway so no algorithmic
changes were neeed.