Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PUPPI JEC configurations and fix MiniAOD to use PUPPI JEC #13175

Merged
merged 1 commit into from Feb 4, 2016

Conversation

ahinzmann
Copy link
Contributor

Configuration sniplets to apply JEC to PUPPI jets are added.

Fix MiniAOD PUPPI jets and PUPPI MET to use the corresponding PUPPI JEC available in all recent global tags (and not use the CHS JEC).

This changes the corrections applied to pfMetT1Puppi and slimmedJetPuppi in MiniAOD.

runTheMatrix.py -l limited -i all
runs without problems.

This PR has not impact on AOD/RECO content, but it contains important fixes necessary for the first 8_0_X MiniAOD.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

A new Pull Request was created by @ahinzmann for CMSSW_8_0_X.

It involves the following packages:

JetMETCorrections/Configuration
PhysicsTools/PatAlgos

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@rappoccio, @imarches, @acaudron, @mmarionncern, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder, @TaiSakuma this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 3, 2016

@cmsbuild please test

This will likely interfere with PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py change in #13115
@ahinzmann , could you please check that #13115 merges cleanly on top of this PR?
If there is a conflict, who wants to wait?

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10978/console

@slava77
Copy link
Contributor

slava77 commented Feb 3, 2016

BTW, this update is 2 days past the deadline and it is not mentioned at https://twiki.cern.ch/twiki/bin/viewauth/CMS/CMSSW_8_0_0 (MET MVA or MET PAT updates were not mentioned there either though).

@ahinzmann
Copy link
Contributor Author

I tried in my ahinzmann:addPuppiJEC branch
git cms-merge-topic cms-met:METCorDev_Jan16_METSig
and it merges without conflicts.
The problem was identified only today, thus not mentioned before.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2016

@slava77
Copy link
Contributor

slava77 commented Feb 4, 2016

+1

for #13175 3c1c983

  • changes in the code are in line with the description
  • jenkins tests pass and comparisons with baseline show differences only in puppi jets and MET monitoring
  • higher stat test on /RelValQCD_FlatPt_15_3000HS_13 in CMSSW_8_0_X_2016-02-02-2300 (includes the latest puppi tuning) shows some improvement, although the response is still not that close to 1 especially in the 40 to 200 GeV range (the corrections probably have not fully caught up with the reco and puppi reco performance updates)
    wf1338hs_jetpuppi_ptcorogen_20to40_vseta
    wf1338hs_jetpuppi_ptcorogen_40to200_vseta
    wf1338hs_jetpuppi_ptcorogen_200to600_vseta

davidlange6 added a commit that referenced this pull request Feb 4, 2016
Add PUPPI JEC configurations and fix MiniAOD to use PUPPI JEC
@davidlange6 davidlange6 merged commit ce79f96 into cms-sw:CMSSW_8_0_X Feb 4, 2016
cmsbuild added a commit that referenced this pull request Feb 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants