New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard Propagator #13187
Standard Propagator #13187
Conversation
A new Pull Request was created by @Ansh0712 (Anshul Kapoor) for CMSSW_8_0_X. It involves the following packages: FastSimulation/Tracking @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
[@cmsbuild,] please test |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@Ansh0712 - could you add a comment about where the "standard propagator" is now used? e.g., "standard propagator now used in fastsim tracking" to the title for our release notes. |
@davidlange6 - Sure !! |
+1 |
diff --cc FastSimulation/Tracking/python/TobTecStep_cff.py index 095bb6d,516d51a..8d8ebc3 --- a/FastSimulation/Tracking/python/TobTecStep_cff.py +++ b/FastSimulation/Tracking/python/TobTecStep_cff.py @@@ -36,14 -36,8 +36,11 @@@ tobTecStepTrackCandidates = FastSimulat hitMasks = cms.InputTag("tobTecStepMasks"), ) +# track fitters +from RecoTracker.IterativeTracking.TobTecStep_cff import tobTecFlexibleKFFittingSmoother,tobTecStepRKTrajectorySmootherForLoopers,tobTecStepRKTrajectorySmoother,tobTecStepRKTrajectoryFitterForLoopers,tobTecStepRKTrajectoryFitter,tobTecStepFitterSmootherForLoopers,tobTecStepFitterSmoother + # tracks - tobTecStepTracks = RecoTracker.IterativeTracking.TobTecStep_cff.tobTecStepTracks.clone( - TTRHBuilder = 'WithoutRefit', - Propagator = 'PropagatorWithMaterial' - ) + tobTecStepTracks = RecoTracker.IterativeTracking.TobTecStep_cff.tobTecStepTracks.clone(TTRHBuilder = 'WithoutRefit') # final selection tobTecStepClassifier1 = RecoTracker.IterativeTracking.TobTecStep_cff.tobTecStepClassifier1.clone()
Standard propagator now used in FastSim Tracking
No significant change in timing is observed !!