Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Propagator #13187

Merged
merged 2 commits into from Feb 5, 2016
Merged

Conversation

a-kapoor
Copy link
Contributor

@a-kapoor a-kapoor commented Feb 4, 2016

Standard propagator now used in FastSim Tracking

No significant change in timing is observed !!

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

A new Pull Request was created by @Ansh0712 (Anshul Kapoor) for CMSSW_8_0_X.

It involves the following packages:

FastSimulation/Tracking

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @matt-komm this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@a-kapoor
Copy link
Contributor Author

a-kapoor commented Feb 4, 2016

[@cmsbuild,] please test

@lveldere
Copy link
Contributor

lveldere commented Feb 4, 2016

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10995/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2016

@lveldere
Copy link
Contributor

lveldere commented Feb 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

@Ansh0712 - could you add a comment about where the "standard propagator" is now used? e.g., "standard propagator now used in fastsim tracking" to the title for our release notes.
Thanks!

@a-kapoor
Copy link
Contributor Author

a-kapoor commented Feb 5, 2016

@davidlange6 - Sure !!

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 5, 2016
@cmsbuild cmsbuild merged commit cbf3964 into cms-sw:CMSSW_8_0_X Feb 5, 2016
cmsbuild added a commit that referenced this pull request Feb 5, 2016
diff --cc FastSimulation/Tracking/python/TobTecStep_cff.py
index 095bb6d,516d51a..8d8ebc3
--- a/FastSimulation/Tracking/python/TobTecStep_cff.py
+++ b/FastSimulation/Tracking/python/TobTecStep_cff.py
@@@ -36,14 -36,8 +36,11 @@@ tobTecStepTrackCandidates = FastSimulat
      hitMasks = cms.InputTag("tobTecStepMasks"),
  )
  
 +# track fitters
 +from RecoTracker.IterativeTracking.TobTecStep_cff import tobTecFlexibleKFFittingSmoother,tobTecStepRKTrajectorySmootherForLoopers,tobTecStepRKTrajectorySmoother,tobTecStepRKTrajectoryFitterForLoopers,tobTecStepRKTrajectoryFitter,tobTecStepFitterSmootherForLoopers,tobTecStepFitterSmoother
 +
  # tracks 
- tobTecStepTracks = RecoTracker.IterativeTracking.TobTecStep_cff.tobTecStepTracks.clone(
-     TTRHBuilder = 'WithoutRefit',
-     Propagator = 'PropagatorWithMaterial'
- )
+ tobTecStepTracks = RecoTracker.IterativeTracking.TobTecStep_cff.tobTecStepTracks.clone(TTRHBuilder = 'WithoutRefit')
  
  # final selection
  tobTecStepClassifier1 = RecoTracker.IterativeTracking.TobTecStep_cff.tobTecStepClassifier1.clone()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants