Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the possibility of additional weights (scale / pdf variation) for Sherpa 2.2, storing the relevant information in GenRunInfoProduct #13230

Closed

Conversation

thuer
Copy link
Contributor

@thuer thuer commented Feb 9, 2016

Adding the possibility of additional weights (scale / pdf variation) for Sherpa 2.2. Sherpa stores the weighst in form of named weights which we do not do in CMSSW, so the relevant names are stored in GenRunInfoProduct

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2016

A new Pull Request was created by @thuer (Sebastian Thüer) for CMSSW_8_0_X.

It involves the following packages:

GeneratorInterface/SherpaInterface
SimDataFormats/GeneratorProducts

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@vciulli
Copy link
Contributor

vciulli commented Feb 9, 2016

This is ok to me

@govoni
Copy link
Contributor

govoni commented Feb 12, 2016

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11173/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2016

Pull request #13230 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please check and sign again.

@covarell
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12279/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@thuer
Copy link
Contributor Author

thuer commented Apr 11, 2016

@covarell We changed it to use the GenLumiInfoHeader in 81X, see #13756 , should I do the same for 80X?

@covarell
Copy link
Contributor

Ah, yes, sorry I thought this was already in the previous commit

@covarell
Copy link
Contributor

-1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants