Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2 alca35 Add IsoTrackFilter for normal physics events #13251

Merged
merged 9 commits into from Feb 15, 2016

Conversation

bsunanda
Copy link
Contributor

Use a new stream for AlCaReco

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_8_0_X.

It involves the following packages:

Calibration/HcalAlCaRecoProducers
Configuration/AlCa

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@mmusich
Copy link
Contributor

mmusich commented Feb 11, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11145/console

@bsunanda
Copy link
Contributor Author

@mmusich May be I have to make it to your AlCaDB meeting on Monday for this requirement

@@ -7,7 +7,8 @@
'DoubleMu' : 'MuAlCalIsolatedMu+MuAlOverlaps+DtCalib+TkAlZMuMu',
'DoubleMuon' : 'TkAlZMuMu+MuAlCalIsolatedMu+MuAlOverlaps+MuAlZMuMu+DtCalib',
'DoubleMuParked' : 'MuAlCalIsolatedMu+MuAlOverlaps+DtCalib+TkAlZMuMu',
'HLTPhysics' : 'SiStripCalMinBias+TkAlMinBias',
'HLTPhysics' : 'SiStripCalMinBias+TkAlMinBias+HcalCalIsoTrkFilter',
'Cosmics' : 'TkAlCosmics0T',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bsunanda the Cosmics key appears here twice. Please remove the unnecessary one.

@mmusich
Copy link
Contributor

mmusich commented Feb 11, 2016

@bsunanda we can certainly discuss the details in the next AlCa/DB meeting. Is this a new AlCaReco that you want to add? As it is now, some things are missing.

@cmsbuild
Copy link
Contributor

Pull request #13251 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Feb 11, 2016

@bsunanda mainly you should add the new AlCaReco here : Configuration/StandardSequences/python/AlCaRecoStreams_cff.py

'keep *_hbhereco_*_*',
'keep *_reducedHcalRecHits_*_*',
'keep *_ecalRecHit_*_*',
'keep *_offlineBeamSpot_*_*',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to get better indentation here?

@cmsbuild
Copy link
Contributor

Pull request #13251 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #13251 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Feb 11, 2016

please test

@cmsbuild
Copy link
Contributor

Pull request #13251 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11172/console

@cmsbuild
Copy link
Contributor

-1
Tested at: a20d9c1
When I ran the RelVals I found an error in the following worklfows:
25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 12-Feb-2016 17:31:41 CET-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

4.22 step1

DAS Error

134.911 step1

DAS Error

140.53 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13251/11172/summary.html

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11177/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

@mmusich Could you approve this so that we an request the filter to be deployed for 2016 data

@mmusich
Copy link
Contributor

mmusich commented Feb 14, 2016

+1

davidlange6 added a commit that referenced this pull request Feb 15, 2016
bsunanda:Run2 alca35 Add IsoTrackFilter for normal physics events
@davidlange6 davidlange6 merged commit 5bd3d97 into cms-sw:CMSSW_8_0_X Feb 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants