-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HF TP Scale. #13290
Fix HF TP Scale. #13290
Conversation
A new Pull Request was created by @akhukhun for CMSSW_8_0_X. It involves the following packages: CalibCalorimetry/CaloTPG @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
Does this PR have an impact on L1 trigger jet energy scales? |
This PR should not change anything for the RCT 3x2 TPs. |
Thanks. I am asking about the 2016 jet trigger, which uses 1x1 TPs. We already see reasonable energy scale (definitely not off by factor 4!) and we used 800pre6 TPs to derive jet energy correction factors. But we will try running with this PR. |
I see. I guess as long as the scales are consistent in the TP emulator and de-compression tables, to first order you should get the same result, up-to granularity/rounding effects. So in your setup I believe you were using RCT scale in both. |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
@akhukhun @abdoulline -so what happens with 2015 MC after this PR? |
On Wed, 24 Feb 2016, David Lange wrote:
|
@davidlange6 - I didn't realize this wasn't merged yet or I would have put it on the ORP list yesterday. Is there any holdup? |
+1 |
Fixing new HF TP scale in the emulator and (un)-compression LUTs.