Fix HF TP Scale.

[akhukhun]

Fixing new HF TP scale in the emulator and (un)-compression LUTs.

[cmsbuild]

A new Pull Request was created by @akhukhun for CMSSW_8_0_X.

It involves the following packages:

CalibCalorimetry/CaloTPG
CalibCalorimetry/HcalTPGAlgos
SimCalorimetry/HcalTrigPrimAlgos
SimCalorimetry/HcalTrigPrimProducers

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[mmusich]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11227/console

[cmsbuild]

+1
Tested at: bfe62f5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13290/11227/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13290/11227/summary.html

[jimbrooke]

Does this PR have an impact on L1 trigger jet energy scales?

[akhukhun]

This PR should not change anything for the RCT 3x2 TPs.
It uses correct scale for new 1x1 TPs in the emulator (so that it's not off by a factor of 4 if based on the RCTlsb value) and, respectively, sets the corresponding scale for TP uncompression tables in the "Transcoder".

[jimbrooke]

Thanks. I am asking about the 2016 jet trigger, which uses 1x1 TPs. We already see reasonable energy scale (definitely not off by factor 4!) and we used 800pre6 TPs to derive jet energy correction factors. But we will try running with this PR.

[akhukhun]

I see. I guess as long as the scales are consistent in the TP emulator and de-compression tables, to first order you should get the same result, up-to granularity/rounding effects. So in your setup I believe you were using RCT scale in both.
Now, I suspect, depending on what gets used for TP decompression in the L1 emulation, CaloTPGTranscoder or pre-generated tables, (which unfortunately I do not know), you may or may not get factor of 4 different results. In the latter case, I think the tables should be re-generated.

[abdoulline]

Dear colleagues
@franzoni, @mmusich, @mulhearn
can you please review it and eventually sign? Thanks.

We need to have it in 80X for correct HF TPs scale...

[mulhearn]

+1

[mmusich]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

[davidlange6]

@akhukhun @abdoulline -so what happens with 2015 MC after this PR?

[abdoulline]

My understanding is - it only affects 1x1 HF TPs (2016 era).

On Wed, 24 Feb 2016, David Lange wrote:

@akhukhun @abdoulline -so what happens with 2015 MC after this PR?

—
Reply to this email directly or view it on
GitHub.[AEx02qx1ZinhYjaV7xl88k726QdbFOcQks5pne2DgaJpZM4HabkX.gif]

[kpedro88]

@davidlange6 - I didn't realize this wasn't merged yet or I would have put it on the ORP list yesterday. Is there any holdup?

[davidlange6]

+1
seems not.