Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECALbyLumi+Timing #13295

Merged
merged 3 commits into from Mar 17, 2016
Merged

ECALbyLumi+Timing #13295

merged 3 commits into from Mar 17, 2016

Conversation

mbandrews
Copy link
Contributor

Fixed bugs in:

  • setting hasLumiPlots_ flag of client MEs
  • preventing unintended reset of Trend client MEs

Added features:

  • by lumi reportSummaryContents for offline dqm (presample check temporary disabled pending better understanding of persistent kBad values)
  • timing for offline dqm
  • timing mean & rms trend plots

Removed Test Pulse from activeSources of calibration quality summary

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbandrews (Michael Andrews) for CMSSW_8_0_X.

It involves the following packages:

DQM/EcalMonitorClient

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Feb 16, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11240/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

@mbandrews
please change the title of this PR to something meaningful for the release notes.
thanks,
F.

@mbandrews mbandrews changed the title 2016 additions ECALbyLumi+Timing Mar 1, 2016
@deguio
Copy link
Contributor

deguio commented Mar 7, 2016

+1
please update the title at:
#13358

it won't be merged otherwise.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 17, 2016
@cmsbuild cmsbuild merged commit b981663 into cms-sw:CMSSW_8_0_X Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants