Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ep combination protection reco 76 #13301

Conversation

rafaellopesdesa
Copy link
Contributor

Similar to #13293, but also in reco part (the reason I am submitting as a different PR is that some of the analysis PR have been already merged).

The W' group reported that the electron Ep combination was returning unphysical values at high energies when the track pT was consistent with 0. We added a protection in the combination code to only use the Ep combination MVA at high energies when the track pT error is smaller than 10 times the track pT. It is a pretty safe cut that removes these badly measured tracks from the determination of the electron energy.

Reference: https://hypernews.cern.ch/HyperNews/CMS/get/physTools/3446/1/1/1/1.html

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rafaellopesdesa (Rafael Lopes de Sa) for CMSSW_7_6_X.

It involves the following packages:

RecoEgamma/EgammaTools

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11250/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Feb 16, 2016

Rafael,
Please clarify if this will be needed in 74X.
I think no, but wanted to confirm.

@rafaellopesdesa
Copy link
Contributor Author

No, this part will not be needed in 74x

Thanks,
Rafael

On Tue, Feb 16, 2016, 9:46 PM Slava Krutelyov notifications@github.com
wrote:

Rafael,
Please clarify if this will be needed in 74X.
I think no, but wanted to confirm.


Reply to this email directly or view it on GitHub
#13301 (comment).

@slava77
Copy link
Contributor

slava77 commented Feb 17, 2016

+1

for #13301 09ad603

  • changes in the code are in line with the description: the protection is added on demand; the default behavior of 76X is unchanged. (based on Ep protection at high energy against crazy tracks .. RECO part #13302 jenkins tests, which show no differences, the condition is fairly rare).
  • jenkins tests pass and comparisons with baseline show no differences as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Feb 23, 2016
…on_reco_76

Ep combination protection reco 76
@davidlange6 davidlange6 merged commit 7259bb1 into cms-sw:CMSSW_7_6_X Feb 23, 2016
@rafaellopesdesa rafaellopesdesa deleted the EPcombination_protection_reco_76 branch February 1, 2017 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants