Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NavigationSchoolAnalyzer for "ByGeom" #13317

Merged
merged 1 commit into from Feb 21, 2016

Conversation

makortel
Copy link
Contributor

This PR fixes NavigationSchoolAnalyzer's "_ByGeom" log output.

Tested in 8_0_0_pre5, no changes expected in standard workflows.

@rovere @VinInn @ebrondol

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_0_X.

It involves the following packages:

RecoTracker/TkNavigation

@cmsbuild, @cvuosalo, @davidlange6, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @istaslis, @gpetruc, @cerati, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 17, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11266/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13317 21de5fa

Minor bug fix for log output from NavigationSchoolAnalyzer. There should be no change in monitored quantities.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-02-16-1100 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@makortel
Copy link
Contributor Author

Closing since this is not needed specifically for 80X and the 81X PR (#13350) was merged.

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Feb 21, 2016
Fix NavigationSchoolAnalyzer for "ByGeom"
@cmsbuild cmsbuild merged commit 7ccd8b8 into cms-sw:CMSSW_8_0_X Feb 21, 2016
@makortel makortel deleted the navigationSchoolAnalyzer branch October 20, 2016 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants