DataFormat and unpacker changes for HF QIE10 (part A)

[kpedro88]

@davidlange6 - I picked out the DataFormats and unpacker changes from #13232. I'm still compiling privately to make sure I didn't forget any dependencies, but I think it should work. For the moment I'll leave #13232 open while I prepare part B.

[cmsbuild]

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_8_0_X.

It involves the following packages:

DataFormats/HcalDigi
EventFilter/HcalRawToDigi

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11284/console

[davidlange6]

Please test

---

From: Kevin Pedro [notifications@github.com]
Sent: 17 February 2016 21:47
To: cms-sw/cmssw
Cc: David Lange
Subject: [cmssw] DataFormat and unpacker changes for HF QIE10 (part A) (#13331)

@davidlange6https://github.com/davidlange6 - I picked out the DataFormats and unpacker changes from #13232#13232. I'm still compiling privately to make sure I didn't forget any dependencies, but I think it should work. For the moment I'll leave #13232#13232 open while I prepare part B.

---

You can view, comment on, or merge this pull request online at:

#13331

Commit Summary

• DataFormat and unpacker changes for HF QIE10 (part A)

File Changes

• M DataFormats/HcalDigi/interface/QIE10DataFrame.hhttps://github.com/DataFormat and unpacker changes for HF QIE10 (part A) #13331/files#diff-0 (40)
• M DataFormats/HcalDigi/interface/QIE11DataFrame.hhttps://github.com/DataFormat and unpacker changes for HF QIE10 (part A) #13331/files#diff-1 (38)
• M DataFormats/HcalDigi/src/QIE10DataFrame.cchttps://github.com/DataFormat and unpacker changes for HF QIE10 (part A) #13331/files#diff-2 (34)
• M DataFormats/HcalDigi/src/QIE11DataFrame.cchttps://github.com/DataFormat and unpacker changes for HF QIE10 (part A) #13331/files#diff-3 (29)
• M DataFormats/HcalDigi/test/HcalDigiDump.cchttps://github.com/DataFormat and unpacker changes for HF QIE10 (part A) #13331/files#diff-4 (8)
• M EventFilter/HcalRawToDigi/interface/HcalUnpacker.hhttps://github.com/DataFormat and unpacker changes for HF QIE10 (part A) #13331/files#diff-5 (2)
• M EventFilter/HcalRawToDigi/plugins/HcalRawToDigi.cchttps://github.com/DataFormat and unpacker changes for HF QIE10 (part A) #13331/files#diff-6 (9)
• M EventFilter/HcalRawToDigi/src/HcalUHTRData.cchttps://github.com/DataFormat and unpacker changes for HF QIE10 (part A) #13331/files#diff-7 (2)
• M EventFilter/HcalRawToDigi/src/HcalUnpacker.cchttps://github.com/DataFormat and unpacker changes for HF QIE10 (part A) #13331/files#diff-8 (96)

Patch Links:

• https://github.com/cms-sw/cmssw/pull/13331.patch
• https://github.com/cms-sw/cmssw/pull/13331.diff

�
Reply to this email directly or view it on GitHubhttps://github.com//pull/13331.

[kpedro88]

Just noticed a dependency that I missed, updated the PR

[cmsbuild]

Pull request #13331 was updated. @civanch, @cvuosalo, @mdhildreth, @cmsbuild, @slava77, @davidlange6 can you please check and sign again.

[davidlange6]

please test

---

From: Kevin Pedro [notifications@github.com]
Sent: 17 February 2016 21:50
To: cms-sw/cmssw
Cc: David Lange
Subject: Re: [cmssw] DataFormat and unpacker changes for HF QIE10 (part A) (#13331)

Just noticed a dependency that I missed, updated the PR

�
Reply to this email directly or view it on GitHubhttps://github.com//pull/13331#issuecomment-185397232.

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11285/console

[davidlange6]

will test in parallel with IB..sorry for taking a shortcut..

[kpedro88]

@davidlange6 - I'm privately compiling partB now (with partA merged manually) to make sure it works. I assume this will get into the 2300 IB, in which case I'll submit the partB PR once that IB is available.

[cmsbuild]

+1
Tested at: 956475a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13331/11284/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13331/11284/summary.html

[cmsbuild]

+1
Tested at: 956475a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13331/11285/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13331/11285/summary.html