Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolation in CITK 80X #13337

Closed

Conversation

ishvetso
Copy link
Contributor

No description provided.

mcepeda and others added 30 commits June 22, 2015 14:01
Removed empty comment line
… are computed wrt (0,0,0) and the correlation is preserved
double url for DQM gui upload of harvesting
…ugfix-74x

Bugfix in L1 GCT ET sums hardware emulator
Fix and update of pede param plotting macros
…ueMapProducer

Fix an uninitialized value in JetDeltaRValueMapProducer
Fixed uninitialized values used by HcalNoiseAlgo
In CastorMonitor and DTSegmentsTask the initialization from
ParameterSet was commented out, I don't know why.
I haven't un-un-commented them, just added initial values.

In QcdPhotonsDQM the variable was used to count the number of events,
and scale the histogram at the endJob.
This should be done via dqm harvesting now what we are multithreaded,
and does not make sense in the DQMEDAnalyzer.
If someone cares or needs the rates (instead of actual
values), we will create a DQMEDHarvester.

In L1TdeCSCTF.cc the array was not properly initialized,
because of the single-character error left by the developer.
2) Conflicts (resolved, only empty lines and verbose comment):	DPGAnalysis/Skims/python/Skims_DPG_cff.py	DPGAnalysis/Skims/python/ZElectronSkim_cff.py
3) exclute newly added Configuration/Skimming/autoSkim.py
endRun makes no sense in multithread mode,
the histogram values would not be correct anyway.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ishvetso (Ivan Shvetsov) for CMSSW_8_0_X.

It involves the following packages:

Alignment/CommonAlignmentProducer
Alignment/MillePedeAlignmentAlgorithm
Alignment/OfflineValidation
Calibration/EcalAlCaRecoProducers
Calibration/EcalCalibAlgos
Calibration/HcalAlCaRecoProducers
Calibration/HcalCalibAlgos
Calibration/HcalIsolatedTrackReco
Calibration/Hotline
Calibration/IsolatedParticles
Calibration/TkAlCaRecoProducers
CommonTools/CandAlgos
CommonTools/RecoAlgos
CommonTools/Utils
CondCore/HcalPlugins
CondCore/Utilities
CondFormats/DataRecord
CondFormats/HcalObjects
CondTools/HLT
CondTools/Hcal
Configuration/AlCa
Configuration/Applications
Configuration/DataProcessing
Configuration/EventContent
Configuration/Generator
Configuration/PyReleaseValidation
Configuration/Skimming
Configuration/StandardSequences
DPGAnalysis/SiStripTools
DPGAnalysis/Skims
DQM/BeamMonitor
DQM/CSCMonitorModule
DQM/CastorMonitor
DQM/DTMonitorClient
DQM/DTMonitorModule
DQM/HcalMonitorTasks
DQM/Integration

@diguida, @cerminar, @fabozzi, @Martin-Grunewald, @covarell, @bendavid, @vanbesien, @govoni, @perrotta, @srimanob, @cmsbuild, @fwyzard, @davidlange6, @vciulli, @cvuosalo, @deguio, @slava77, @ggovi, @vadler, @mmusich, @boudoul, @thuer, @monttj, @franzoni, @hengne can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @abbiendi, @argiro, @Martin-Grunewald, @tlampen, @threus, @venturia, @pakhotin, @makortel, @jhgoh, @jdolen, @cerati, @barvic, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @mschrode, @mmusich, @dgulhan, @apfeiffer1, @batinkov, @ahinzmann this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@ishvetso ishvetso changed the title Photon isolation in CITK 80X Isolation in CITK 80X Feb 18, 2016
@mmusich
Copy link
Contributor

mmusich commented Feb 18, 2016

-1
needs a rebase

@slava77
Copy link
Contributor

slava77 commented Feb 18, 2016

-1
rebase, cherry-pick, or redo from scratch in 80X

@ishvetso
Copy link
Contributor Author

I have created a rebased branch for 80X and created a new PR:
#13391

@ishvetso ishvetso closed this Feb 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment