Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HGCal L1 Trigger Framework #13371

Merged
merged 40 commits into from Apr 12, 2016
Merged

HGCal L1 Trigger Framework #13371

merged 40 commits into from Apr 12, 2016

Conversation

cmsbuild
Copy link
Contributor

This pull request defines packages for and implements much of the basic functionality for the HGCal L1 trigger emulator.

I will issue pull requests to CMS bot to add the packages to the watchlists.

@jbsauvan @amarini @mulhearn
Automatically ported from CMSSW_8_0_X #13156 (original by @lgray).

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Feb 18, 2016
@cmsbuild
Copy link
Contributor Author

A new Pull Request was created by @cmsbuild for CMSSW_8_1_X.

It involves the following packages:

DataFormats/ForwardDetId
DataFormats/L1THGCal
L1Trigger/L1THGCal

@cmsbuild, @civanch, @mulhearn, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @jbsauvan, @lgray this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@civanch
Copy link
Contributor

civanch commented Feb 23, 2016

please test

@cmsbuild
Copy link
Contributor Author

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11482/console

@cmsbuild
Copy link
Contributor Author

+1
Tested at: 27354f1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13371/11482/summary.html

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13371/11482/summary.html

@civanch
Copy link
Contributor

civanch commented Feb 26, 2016

+1

@cmsbuild
Copy link
Contributor Author

+1
Tested at: 182d570
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13371/12009/summary.html

@mdhildreth
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor Author

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13371/12009/summary.html

@lgray
Copy link
Contributor

lgray commented Mar 24, 2016

@mulhearn Please sign this PR!

@lgray
Copy link
Contributor

lgray commented Mar 28, 2016

@mulhearn Please sign this PR! Thanks!

@mulhearn
Copy link
Contributor

mulhearn commented Apr 4, 2016

+1

@cmsbuild
Copy link
Contributor Author

cmsbuild commented Apr 4, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@lgray
Copy link
Contributor

lgray commented Apr 5, 2016

@davidlange6 Any possibility to move forward with this?

@lgray
Copy link
Contributor

lgray commented Apr 10, 2016

@davidlange6 Please merge this ASAP.

@lgray
Copy link
Contributor

lgray commented Apr 12, 2016

@davidlange6 ping!

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2076a95 into cms-sw:CMSSW_8_1_X Apr 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available fully-signed l1-approved orp-approved simulation-approved tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@cmsbuild @civanch @lgray @mdhildreth @mulhearn @davidlange6 @jbsauvan @amarini