Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoNCorrOnTrack in modules with the highest values #13413

Merged

Conversation

rrabadan
Copy link
Contributor

modules that have a S/N corrected by track angle less than 10 added in list of modules with highest values

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rrabadan (Raul Rabadan) for CMSSW_8_0_X.

It involves the following packages:

DQM/SiStripMonitorClient

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @venturia this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Feb 22, 2016

please test

@deguio
Copy link
Contributor

deguio commented Feb 22, 2016

please submit to 80x as well

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11443/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@rrabadan
Copy link
Contributor Author

sign please

@deguio
Copy link
Contributor

deguio commented Mar 1, 2016

ciao @rrabadan
sorry in my previous message I meant: Please submit to 81x as well.
could you please indicate the corresponding PR for 81x?
thanks,
F.

@rrabadan
Copy link
Contributor Author

rrabadan commented Mar 2, 2016

PR for 81X: 13560

@deguio
Copy link
Contributor

deguio commented Mar 7, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 17, 2016
…alues

StoNCorrOnTrack in  modules with the highest values
@cmsbuild cmsbuild merged commit e750bd8 into cms-sw:CMSSW_8_0_X Mar 17, 2016
@@ -112,9 +112,9 @@
cms.PSet(mapName=cms.untracked.string('NumberOfOfffTrackCluster'),TopModules=cms.untracked.bool(True)),
cms.PSet(mapName=cms.untracked.string('NumberOfOfffTrackCluster'),mapSuffix=cms.untracked.string("_autoscale"),mapMax=cms.untracked.double(-1.)),
cms.PSet(mapName=cms.untracked.string('NumberOfOnTrackCluster')),
cms.PSet(mapName=cms.untracked.string('StoNCorrOnTrack')),
cms.PSet(mapName=cms.untracked.string('StoNCorrOnTrack',TopModules=cms.untracked.bool(True)),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto merge job (80X changes in to 81X) failed to resolve the above? Is not there a missing ')' after 'StoNCorrOnTrack'? In 81X we have 0249733#diff-da712dd5a8dd05d67efa0e78be33b175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants