Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thread safety statics work L1Trigger-GlobalTrigger #1342

Merged
merged 1 commit into from
Nov 6, 2013
Merged

thread safety statics work L1Trigger-GlobalTrigger #1342

merged 1 commit into from
Nov 6, 2013

Conversation

gartung
Copy link
Member

@gartung gartung commented Nov 5, 2013

L1GtAlgorithmEvaluation::evaluateAlgorithm::returnStack can be made non-static since it is essentially deleted at the end of the function

…on-static since it is essentially deleted at the end of the function
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2013

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_0_X.

thread safety statics work L1Trigger-GlobalTrigger

It involves the following packages:

L1Trigger/GlobalTrigger

@cmsbuild, @nclopezo, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2013

@mulhearn
Copy link
Contributor

mulhearn commented Nov 6, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Nov 6, 2013
Multithreading fixes -- Some statics removed from L1Trigger/GlobalTrigger
@ktf ktf merged commit a9e33fe into cms-sw:CMSSW_7_0_X Nov 6, 2013
@gartung gartung deleted the statics-L1Trigger-GlobalTrigger branch November 6, 2013 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants