Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update trajectory filters (minNumberOfHits --> minNumberOfHitsForLoopers) #13436

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Feb 23, 2016

as requested by @slava77
this PR is the same code update as in PR #13421
but for 81x

@Martin-Grunewald @perrotta @rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for CMSSW_8_1_X.

It involves the following packages:

HLTrigger/Configuration
TrackingTools/TrajectoryFiltering

@perrotta, @cmsbuild, @cvuosalo, @slava77, @Martin-Grunewald, @fwyzard, @davidlange6 can you please review it and eventually sign? Thanks.
@geoff-smith, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @bellan, @jalimena, @cerati, @gpetruc, @istaslis, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11475/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13436 91f9442

Code clean-up of trajectory filters. There should be no change in monitored quantities. #13421 is the 80X version of this PR, and it has already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-02-22-1100 show no significant differences, as expected.

@mtosi
Copy link
Contributor Author

mtosi commented Mar 3, 2016

can this PR be integrated ?
thanks

@Martin-Grunewald
Copy link
Contributor

after the l1extra migration!

@davidlange6
Copy link
Contributor

this PR looks obsolete (and would need rebasing) - closing for now.

@mtosi
Copy link
Contributor Author

mtosi commented May 2, 2016

I'm preparing a new branch in 81x
hope it is fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants