Adds option to EcalDeadCellTriggerPrimitiveFilter to consider kTPSaturated flag #13429
Conversation
…r, "modekTPSaturated" The parameter is added to allow consideration of the RecHit flag, kTPSaturated modekTPSaturated = 0; classical operation modekTPSaturated = 1; event tagged if either the trigger tower sum exceeds the provided threshold energy or if the kTPSaturated flag is set modekTPSaturated = 2; event is tagged on if the kTPSaturated flag is set.
…gerPrimitiveFilter
|
A new Pull Request was created by @kencall for CMSSW_8_1_X. It involves the following packages: RecoMET/METFilters @cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| @@ -158,6 +162,9 @@ class EcalDeadCellTriggerPrimitiveFilter : public edm::EDFilter { | |||
|
|
|||
| bool useTPmethod_, useHITmethod_; | |||
|
|
|||
| bool exclusivelykTPSaturated_; | |||
| bool considerkTPSaturated_; | |||
There was a problem hiding this comment.
I'm not sure why these two are added: there are not used in the class methods.
Please clarify.
There was a problem hiding this comment.
Hi Slava,
During development these names were used before the options useTTsum_ and usekTPSaturated_ were added. These two lines were left behind when the code was cleaned up in preparation for the PR. They can be removed, and I've updated the PR with them removed.
Regards,
Ken Call
From: Slava Krutelyov [notifications@github.com]
Sent: Wednesday, February 24, 2016 6:28 AM
To: cms-sw/cmssw
Cc: Call, Ken
Subject: Re: [cmssw] Adds option to EcalDeadCellTriggerPrimitiveFilter to consider kTPSaturated flag (#13429)
In RecoMET/METFilters/plugins/EcalDeadCellTriggerPrimitiveFilter.cchttps://github.com//pull/13429#discussion_r53937346:
@@ -158,6 +162,9 @@ class EcalDeadCellTriggerPrimitiveFilter : public edm::EDFilter {
bool useTPmethod_, useHITmethod_;
- bool exclusivelykTPSaturated_;
- bool considerkTPSaturated_;
I'm not sure why these two are added: there are not used in the class methods.
Please clarify.
—
Reply to this email directly or view it on GitHubhttps://github.com//pull/13429/files#r53937346.
Removed exclusivelykTPSaturated_ and considerkTPSaturated_
cmsbuild
added
tests-pending
comparison-pending
and removed
comparison-available
tests-approved
labels
|
The tests are being triggered in jenkins. |
|
-1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log 135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log you can see the results of the tests here: |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
cmsbuild
added
reconstruction-approved
tests-pending
tests-started
and removed
reconstruction-pending
tests-rejected
tests-pending
labels
|
-1 runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log 135.4 step1 runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log you can see the results of the tests here: |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
| if( toDo ){ | ||
|
|
||
| //If we considerkTPSaturated and a recHit has a flag set, we can immediately flag the event. | ||
| if(ebrechit->checkFlag(EcalRecHit::kTPSaturated) && usekTPSaturated_) return 1; |
There was a problem hiding this comment.
@kencall would be more efficient to first check useTPSaturated_ here and below. Something to consider for your next PR.
Adds option to EcalDeadCellTriggerPrimitiveFilter to consider kTPSaturated flag
Ecal rechits have the flag, kTPSaturated, available. The filter has be updated and given a configurable option to consider this flag. The default configuration maintains the classical behavior.
Validation of the use of kTPSaturated is presented here: https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/2015D-EcalTP.pdf
Regards,
Ken Call