Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7_0_X improvements in TrackingParticle visualization, hide FF proxy builder from cmsShow AddCollection dialog #1343

Merged
merged 12 commits into from Nov 6, 2013

Conversation

alja
Copy link
Contributor

@alja alja commented Nov 5, 2013

Fireworks/FWInterface:
Optimize FF TrackingParticle with hits proxy builder
Fix potential crash -- add check for collection in FF Tracks proxy builder

Fireworks/Core:
Hide FullFramework proxy builders -- the condition is FF proxy builder class name ends with FullFramework. Therefore the existing proxy builders are named TrackingParticleProxyBuilderFullFramework and TracksProxyBuilderFullFramework.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2013

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_0_X.

7_0_X improvements in TrackingParticle visualization, hide FF proxy builder from cmsShow AddCollection dialog

It involves the following packages:

Fireworks/FWInterface
Fireworks/Core

@cmsbuild, @alja, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2013

@ktf
Copy link
Contributor

ktf commented Nov 6, 2013

+1

@alja please approve your pull requests when you are happy. You now have the superpowers. ;)

ktf added a commit that referenced this pull request Nov 6, 2013
Fireworks -- TrackingParticle visualization improvements.
@ktf ktf merged commit fedb5f4 into cms-sw:CMSSW_7_0_X Nov 6, 2013
@alja
Copy link
Contributor Author

alja commented Nov 6, 2013

@ktf How do I approve pull request?

@ktf
Copy link
Contributor

ktf commented Nov 6, 2013

@ktf How do I approve pull request?

+1 in the first line (look at the message from cmsbuild).

Ciao,

Giulio

Office: 6-2-25 CERN
Tel: +41227671799
GitHub: http://github.com/ktf/

@alja alja deleted the addcollectionFF branch April 15, 2014 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants