Fix incorrect exception message #13432
Conversation
|
A new Pull Request was created by @wmtan for CMSSW_8_1_X. It involves the following packages: DataFormats/Provenance @cmsbuild, @smuzaffar, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
| // Duplicate registration in current process | ||
| throw Exception(errors::LogicError , "Duplicate Product") | ||
| << "The produced product " << previous.second << " is registered more than once.\n" | ||
| << "Please remove the redundant 'produces' call(s).\n"; |
There was a problem hiding this comment.
Will the exception message contain the name of the module?
|
@wmtan ping |
|
@Dr15Jones |
|
@Dr15Jones ping Can you sign this? |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
Fix incorrect exception message
There is an existing exception message designed for the case where the reuse of a process name results in a duplicate product of the same type with the same input tag.
Unfortunately, the same exception is thrown when the duplication is a result of the same product being registered more than once in the current process. In this second case, the exception message is not only misleading, but flat out wrong.
This PR distinguishes the two cases, and adds a new exception to be thrown in the second case.
This PR solves issue #13268