Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change selector to stream for multithreading #13451

Conversation

kirschen
Copy link
Contributor

in order to be able to use the module at HLT as well.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kirschen for CMSSW_8_1_X.

It involves the following packages:

CommonTools/ParticleFlow

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2016

@cmsbuild please test

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13451 1f97dd7

Small fix to GenericPFCandidateSelector to support multi-threading for possible use by HLT. There should be no change in monitored quantities. #13452 is the 80X version of this PR.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_1_X_2016-02-23-2300 show no significant differences, as expected.

davidlange6 added a commit that referenced this pull request Feb 25, 2016
…eSelector

change selector to stream for multithreading
@davidlange6 davidlange6 merged commit 39ac3de into cms-sw:CMSSW_8_1_X Feb 25, 2016
@cmsbuild
Copy link
Contributor

-1
Tested at: 1f97dd7
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13451/11532/summary.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants