Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change selector to stream for multithreading #13452

Conversation

kirschen
Copy link
Contributor

backport of #13451

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kirschen for CMSSW_8_0_X.

It involves the following packages:

CommonTools/ParticleFlow

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2016

@cmsbuild please test
@kirschen
I guess you also need this in 76X

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11493/console

@kirschen
Copy link
Contributor Author

Hi Slava,

the JIRA-ticket this has to do with is https://its.cern.ch/jira/browse/CMSHLT-586
@Martin-Grunewald suggested to do it in 80X/81X for now.

Cheers,
Henning

@slava77
Copy link
Contributor

slava77 commented Feb 24, 2016

Hi Henning,

The selector looks generic enough that it may be useful in analysis.
I guess we can just keep it in mind for now and stay with just 8X.

Slava

@cmsbuild
Copy link
Contributor

-1
Tested at: 1f97dd7
When I ran the RelVals I found an error in the following worklfows:
4.22 step1

DAS Error

134.911 step1

DAS Error

140.53 step1

DAS Error

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13452/11493/summary.html

@cvuosalo
Copy link
Contributor

@cmsbuild please test
DAS error -- trying again

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #13452 1f97dd7

Small fix to GenericPFCandidateSelector to support multi-threading for possible use by HLT. There should be no change in monitored quantities. #13451 is the 81X version of this PR, and it has already been approved by Reco.

The code change is satisfactory, and Jenkins tests against baseline CMSSW_8_0_X_2016-02-23-2300 show no significant differences, as expected.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Mar 1, 2016
…eSelector

change selector to stream for multithreading
@davidlange6 davidlange6 merged commit fdddf7a into cms-sw:CMSSW_8_0_X Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants