Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Me0 digitizer constand phi smearing 800 #13478

Conversation

pietverwilligen
Copy link
Contributor

Make configuration file of ME0Digitizer configurable such that one can choose between constant phi smearing in local coordinates (e.g. 500um everywhere) or constant phi smearing in radians 0.019* (=3.3E-4 rad) everywhere.

at R=62cm, a smearing of 500um corresponds to 0.046* = 8.1E-4 rad
at R=150cm, a smearing of 500um corresponds to 0.019* = 3.3E-4 rad

Port of #13397 to 81X. Corresponding SLHCDEV PR is #13396.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pietverwilligen (Piet Verwilligen) for CMSSW_8_1_X.

It involves the following packages:

SimMuon/GEMDigitizer

@cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks.
@jhgoh this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@civanch
Copy link
Contributor

civanch commented Feb 25, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11554/console

@cmsbuild
Copy link
Contributor

-1
Tested at: 3ce3f16
When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13478/11554/summary.html

@civanch
Copy link
Contributor

civanch commented Feb 26, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11579/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Feb 26, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Feb 27, 2016
…hiSmearing_800

Me0 digitizer constand phi smearing 800
@davidlange6 davidlange6 merged commit a32678c into cms-sw:CMSSW_8_1_X Feb 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants