Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70X Validation/Performance/scripts/cmsPerfStripChart.py update #1350

Merged
merged 1 commit into from Nov 11, 2013

Conversation

dnikolop
Copy link
Contributor

@dnikolop dnikolop commented Nov 6, 2013

@ktf

  • Removed the error bars from the dates (x-axis) in the produced histogram.
  • Changed IB's to IBs shown in plot.
  • Implement a helper function get_yaxis_range using built-in functions min(), max(), that returns the proper range of y-axis of the average-CPU histogram.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2013

A new Pull Request was created by @dnikolop for CMSSW_7_0_X.

70X Validation/Performance/scripts/cmsPerfStripChart.py update

It involves the following packages:

Validation/Performance

@cmsbuild, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@@ -113,7 +113,7 @@ def operate(timelog, memlog, json_f, num):
json_db = open(json_f, "w+")
json.dump(dict, json_db, indent=2)
json_db.close()
print 'File \"%s\" was updated successfully!' % json_f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general prefer %s to + +.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2013

ktf added a commit that referenced this pull request Nov 11, 2013
Utilities improvements -- 70X Validation/Performance/scripts/cmsPerfStripChart.py update
@ktf ktf merged commit 1c1d004 into cms-sw:CMSSW_7_0_X Nov 11, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants