Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all [-Wheader-guard] warnings #13515

Merged
merged 1 commit into from Feb 29, 2016

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Feb 28, 2016

The patch fixes 138 warnings of the following format:

warning: '<..>' is used as a header guard here,
followed by #define of a different macro [-Wheader-guard]

Tested with Clang 3.8.0.

Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch

The patch fixes 138 warnings of the following format:

    warning: '<..>' is used as a header guard here,
    followed by #define of a different macro [-Wheader-guard]

Tested with Clang 3.8.0.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlt for CMSSW_8_1_X.

It involves the following packages:

Calibration/EcalAlCaRecoProducers
CondCore/CondDB
CondFormats/DataRecord
DQM/BeamMonitor
DQM/RCTMonitor
DQM/SiStripCommissioningSources
DQMOffline/Hcal
DQMServices/Components
DQMServices/Diagnostic
FWCore/MessageLogger
FastSimulation/MaterialEffects
Fireworks/ParticleFlow
GeneratorInterface/PartonShowerVeto
GeneratorInterface/Pythia8Interface
Geometry/ForwardGeometry
Geometry/TrackerNumberingBuilder
HLTrigger/special
L1Trigger/RegionalCaloTrigger
PhysicsTools/JetMCUtils
RecoLocalCalo/EcalDeadChannelRecoveryAlgos
RecoLocalMuon/DTRecHit
RecoParticleFlow/PFProducer
RecoTracker/SiTrackerMRHTools
SimGeneral/DataMixingModule
Validation/RPCRecHits

@diguida, @lveldere, @ianna, @cerminar, @Martin-Grunewald, @covarell, @bendavid, @vanbesien, @govoni, @perrotta, @civanch, @cmsbuild, @fwyzard, @davidlange6, @vciulli, @smuzaffar, @Dr15Jones, @cvuosalo, @mdhildreth, @deguio, @slava77, @ggovi, @vadler, @mmusich, @mulhearn, @ssekmen, @thuer, @monttj, @alja, @franzoni can you please review it and eventually sign? Thanks.
@ghellwig, @argiro, @Martin-Grunewald, @threus, @venturia, @mmarionncern, @imarches, @makortel, @acaudron, @jhgoh, @lgray, @ferencek, @cerati, @rociovilar, @barvic, @wmtan, @GiacomoSguazzoni, @rovere, @VinInn, @bellan, @tocheng, @istaslis, @mschrode, @dgulhan, @apfeiffer1, @mkirsano, @wddgit, @alja, @gpetruc, @matt-komm, @pvmulder, @bachtis this is something you requested to watch as well.
@slava77, @degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlt
Copy link
Contributor Author

davidlt commented Feb 28, 2016

Test are already triggered.

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

@Dr15Jones
Copy link
Contributor

+1

@slava77
Copy link
Contributor

slava77 commented Feb 28, 2016

+1

for #13515 6f5df11

  • code changes are in line with the description
  • jenkins tests pass

@lveldere
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Feb 29, 2016

+1

davidlange6 added a commit that referenced this pull request Feb 29, 2016
Fix all [-Wheader-guard] warnings
@davidlange6 davidlange6 merged commit 0cd8367 into cms-sw:CMSSW_8_1_X Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment