Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trackingOnly DQM #13517

Merged
merged 1 commit into from Mar 8, 2016
Merged

Conversation

makortel
Copy link
Contributor

TrackingOnly DQM currently fails with

$ cmsDriver.py step3_trk --datatier DQMIO --conditions auto:run1_mc -s RAW2DIGI,RECO:reconstruction_trackingOnly,VALIDATION:@trackingOnlyValidation,DQM:@trackingOnlyDQM --eventcontent DQM -n 100 --filein file:step2.root --fileout file:step3_inDQM.root --no_exec
...
Traceback (most recent call last):
  File ".../CMSSW_8_0_0/bin/slc6_amd64_gcc493/cmsDriver.py", line 55, in <module>
    run()
  File ".../CMSSW_8_0_0/bin/slc6_amd64_gcc493/cmsDriver.py", line 27, in run
    configBuilder.prepare()
  File ".../CMSSW_8_0_0/python/Configuration/Applications/ConfigBuilder.py", line 2058, in prepare
    self.addStandardSequences()
  File ".../CMSSW_8_0_0/python/Configuration/Applications/ConfigBuilder.py", line 741, in addStandardSequences
    getattr(self,"prepare_"+stepName)(sequence = '+'.join(stepSpec))
  File ".../CMSSW_8_0_0/python/Configuration/Applications/ConfigBuilder.py", line 1961, in prepare_DQM
    setattr(self.process,pathName, cms.Path( getattr(self.process, sequence) ) )
AttributeError: 'Process' object has no attribute 'DQMHarvestTracking'

I believe it got broken in #12604, and this PR fixes it.

Tested in 8_0_0, no changes expected. The branch is based on 8_0_0, so placing a corresponding PR for 80X, if needed, is trivial.

@rovere @VinInn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

DQMOffline/Configuration

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@VinInn
Copy link
Contributor

VinInn commented Mar 4, 2016

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11715/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2016

@deguio
Copy link
Contributor

deguio commented Mar 7, 2016

+1
thanks. I simply missed that entry in my original PR.
sorry about that.
F.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 8, 2016
@cmsbuild cmsbuild merged commit 5c84601 into cms-sw:CMSSW_8_1_X Mar 8, 2016
@makortel makortel deleted the fixTrackingOnlyDQM branch October 20, 2016 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants