Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Partial Sim/Reco Geometry Dump #13525

Merged
merged 1 commit into from Mar 1, 2016
Merged

Enable Partial Sim/Reco Geometry Dump #13525

merged 1 commit into from Mar 1, 2016

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Feb 29, 2016

  • Allow partial sim/reco geometry dump in TGeo and root formats. Useul for testbeam tests
  • Add flags for Muon, Calo and Tracker dumps
  • Ceanup obsolete geometry dump
  • Add testbeam geometries
  • Use appropriate conditions

@ianna
* Allow partial sim/reco geometry dump in TGeo and root formats. Usef…
974d7a6 
…ul for testbeam tests

* Add flags for Muon, Calo and Tracker dumps
* Ceanup obsolete geometry dump
* Add testbeam geometries
* Use appropriate conditions
@ianna
Copy link
Contributor Author

ianna commented Feb 29, 2016

please test

@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Feb 29, 2016
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11614/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for CMSSW_8_1_X.

It involves the following packages:

Fireworks/Geometry

@cmsbuild, @alja, @Dr15Jones, @davidlange6 can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@cmsbuild
Copy link
Contributor

+1
Tested at: 974d7a6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13525/11614/summary.html

@alja
Copy link
Contributor

alja commented Feb 29, 2016

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2016

Comparison not run due to Fireworks only changes

@davidlange6
Copy link
Contributor

+1
(if this is a new cmsbot feature, could it also remove the comparison-pending flag? @smuzaffar

cmsbuild added a commit that referenced this pull request Mar 1, 2016
@cmsbuild
Merge pull request #13525 from ianna/partial-geometry-display
e8a028d 
Enable Partial Sim/Reco Geometry Dump
@cmsbuild cmsbuild merged commit e8a028d into cms-sw:CMSSW_8_1_X Mar 1, 2016
@smuzaffar
Copy link
Contributor

It should have properly updated the labels (i.e. removed comparison-pending lebal and add comparison notrun label), which I think it did (just re-tested :-) )

Not running matrix and comparison for Fireworks only PR is an old feature but now bot properly update the PR to inform why/what was not run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-notrun fully-signed orp-approved tests-approved visualization-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ianna @cmsbuild @alja @davidlange6 @smuzaffar