Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to guns to allow finite decay length for mothers #13527

Merged
merged 1 commit into from Mar 2, 2016

Conversation

smrenna
Copy link
Contributor

@smrenna smrenna commented Feb 29, 2016

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smrenna (Stephen Mrenna) for CMSSW_8_1_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @davidlange6, @govoni can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@govoni
Copy link
Contributor

govoni commented Mar 2, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11665/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2016

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Mar 2, 2016
Modifications to guns to allow finite decay length for mothers
@cmsbuild cmsbuild merged commit fcead5f into cms-sw:CMSSW_8_1_X Mar 2, 2016
(fMasterGen->event).append( particleID, 1, 0, 0, -px, -py, -pz, ee, mass );
int eventSize = (fMasterGen->event).size()-1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the closing brace is misplaced here.
Compare to EGun.
Here we end up with tau set only if "-particleID" is not a particle

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a proposed fix in #16743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants