Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove static_cast #1356

Merged
merged 1 commit into from Nov 7, 2013
Merged

Remove static_cast #1356

merged 1 commit into from Nov 7, 2013

Conversation

vkuznet
Copy link
Contributor

@vkuznet vkuznet commented Nov 6, 2013

No description provided.

@vkuznet
Copy link
Contributor Author

vkuznet commented Nov 6, 2013

@Dr15Jones please review

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2013

A new Pull Request was created by @vkuznet (Valentin Kuznetsov) for CMSSW_7_0_X.

Remove static_cast

It involves the following packages:

FastSimulation/TrackerSetup

@cmsbuild, @nclopezo, @giamman, @lveldere can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2013

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/1235/summary.html

@giamman
Copy link
Contributor

giamman commented Nov 7, 2013

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2013

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf
ktf reviewed Nov 7, 2013
View reviewed changes
FastSimulation/TrackerSetup/interface/TrackerInteractionGeometry.h
@@ -47,7 +47,7 @@ class TrackerInteractionGeometry

/// Returns the number of cylinders in the Tracker
inline const int nCylinders() const
{ return static_cast<const int>(_theCylinders.size()); }
{ return _theCylinders.size(); }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also no need to have it "const int" since in any case you copy it...

ktf added a commit that referenced this pull request Nov 7, 2013
@ktf
Merge pull request #1356 from vkuznet/ThreadSafe_FastSimulation_Track…
f105afc 
…erSetup

Multithreading fixes -- Remove static_cast in FastSimulation/TrackerSetup
@ktf ktf merged commit f105afc into cms-sw:CMSSW_7_0_X Nov 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fastsim-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_0_0_pre9
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vkuznet @cmsbuild @giamman @ktf