Fix QuickTrackAssociatorByHits for empty TrackingParticleRefVector #13570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkClusterMapProductID() fails for empty TrackingParticleRefVector as it has ProductID 0:0.
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: SimTracker/TrackAssociatorProducers @cmsbuild, @civanch, @mdhildreth, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
please test |
|
The tests are being triggered in jenkins. |
davidlange6
added a commit
that referenced
this pull request
Mar 3, 2016
Fix QuickTrackAssociatorByHits for empty TrackingParticleRefVector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in #13348: empty TrackingParticleRefVector has ProductID 0:0 and thus failes a check against the ProductID for mapped objects in ClusterTPAssociation.
Tested in CMSSW_8_1_X_2016-03-02-2300, the workflows 11.0,1311.0,1323.0 that are failing in the IB should get fixed.