Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix track validation for heavy ions #13579

Merged
merged 2 commits into from Mar 8, 2016

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Mar 3, 2016

This PR fixes two bugs introduced in #13348

  • MultiTrackValidator now expects TrackingParticles for efficiency to be a subset of TPs for fakes. HI configuration has selections for both, so the selections need to be done with Refs instead of copies (copies cause exception to be thrown by MTV).
  • trackingParticleNumberOfLayersProducer needs to be added to the sequence

Tested in CMSSW_8_1_X_2016-03-02-2300, the workflows 140.1,140.2,140.4,145.0,301.0,302.0 that are failing in the IB should get fixed.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X.

It involves the following packages:

Validation/RecoHI
Validation/RecoTrack

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@kkrajczar, @GiacomoSguazzoni, @rovere, @VinInn, @cerati, @richard-cms, @RylanC24, @wmtford, @istaslis, @dgulhan this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlange6
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11694/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2016

davidlange6 added a commit that referenced this pull request Mar 8, 2016
Fix track validation for heavy ions
@davidlange6 davidlange6 merged commit 72cef4a into cms-sw:CMSSW_8_1_X Mar 8, 2016
@makortel makortel deleted the fixMTVforHI branch October 20, 2016 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants