Adding 1x1 HF trigger primitives in Hcal Geometry tags #13581

mmusich · 2016-03-03T12:17:10Z

Summary of changes in Global Tags

RunII simulation

RunII Ideal scenario : 80X_mcRun2_design_v6 as 80X_mcRun2_design_v5 with the following changes:
- updated HcalParameters and Sim geometry to handle 1x1 HF TPs
RunII CRAFT scenario : 80X_mcRun2cosmics_startup_peak_v4 as 80X_mcRun2cosmics_startup_peak_v5 with the following changes:
- updated HcalParameters and Sim geometry to handle 1x1 HF TPs
RunII Asymptotic scenario : 80X_mcRun2_asymptotic_v6 as 80X_mcRun2_asymptotic_v5 with the following changes:
- updated HcalParameters and Sim geometry to handle 1x1 HF TPs
RunII Startup scenario : 80X_mcRun2_startup_v6 as 80X_mcRun2_startup_v5 with the following changes:
- updated HcalParameters and Sim geometry to handle 1x1 HF TPs
RunII Heavy Ions scenario : 80X_mcRun2_HeavyIon_v5 as 80X_mcRun2_HeavyIon_v4 with the following changes:
- updated HcalParameters and Sim geometry to handle 1x1 HF TPs

RunII data

RunII HLTHI processing : 80X_dataRun2_HLTHI_frozen_v6 as 80X_dataRun2_HLTHI_frozen_v3 with the following changes:
- updated HcalParameters to handle 1x1 HF TPs
- updated Hcal e-maps (unlabeled and full) for unpacking of uTCA FEDs in HBHE
RunII HLT relval processing : 80X_dataRun2_HLT_relval_v3 as 80X_dataRun2_HLT_relval_v1 with the following changes:
- updated HcalParameters to handle 1x1 HF TPs
- udated Hcal e-maps (unlabeled and full) for unpacking of uTCA FEDs in HBHE
RunII HLT processing : 80X_dataRun2_HLT_frozen_v6 as 80X_dataRun2_HLT_frozen_v3 with the following changes:
- updated HcalParameters to handle 1x1 HF TPs
- udated Hcal e-maps (unlabeled and full) for unpacking of uTCA FEDs in HBHE
RunII Offline processing : 80X_dataRun2_v8 as 80X_dataRun2_v6 with the following changes:
- updated HcalParameters to handle 1x1 HF TPs
RunII Offline relval processing : 80X_dataRun2_relval_v3 as 80X_dataRun2_relval_v1 with the following changes:
- updated HcalParameters to handle 1x1 HF TPs

cmsbuild · 2016-03-03T12:17:30Z

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_8_0_X.

It involves the following packages:

Configuration/AlCa

@diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald, @tocheng this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

mmusich · 2016-03-03T12:31:18Z

please test

cmsbuild · 2016-03-03T12:31:34Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11692/console

mmusich · 2016-03-03T13:25:22Z

@davidlange6 these are the GTs we've been promising during the Operations meeting today
@hengne, please notice that I had to update the autoCond file. The phase-I didn't receive further updates (waiting for #13516 to be merged)

cmsbuild · 2016-03-03T15:41:52Z

-1
Tested at: ab7cdfc
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

134.911 step3

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13581/11692/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
326102c
a75a09e
654b096
3e6fdb0
cad854b
8e8ed3d
f89595f
0e27df5
fdddf7a
dc44cd8
e4b1500
a5c91fe
440e538
0485b63
c759cab
5c54649
98e00d0
126eaa8
f995a9a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13581/11692/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13581/11692/git-merge-result

davidlange6 · 2016-03-03T15:51:23Z

this probably needs to use a more recent IB. (as Slava already noticed jenkins is behind)

#5 0x00007f24fac06796 in CaloTPGTranscoderULUT::hcalCompress(HcalTrigTowerDetId const&, unsigned int, bool) const () from /cvmfs/cms-ib.cern.ch/2016-10/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-28-0000/lib/slc6_amd64_gcc493/libCalibCalorimetryCaloTPG.so
#6 0x00007f24fac0052e in HcalTPGCompressor::compress(IntegerCaloSamples const&, std::vector<bool, std::allocator > const&, HcalTriggerPrimitiveDigi&) const () from /cvmfs/cms-ib.cern.ch/2016-10/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-28-0000/lib/slc6_amd64_gcc493/libCalibFormatsCaloTPG.so
#7 0x00007f24c3c4afaf in HcalTriggerPrimitiveAlgo::analyzeHFV1(IntegerCaloSamples const&, HcalTriggerPrimitiveDigi&, int, HcalFeatureBit const_) () from /cvmfs/cms-ib.cern.ch/2016-10/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-28-0000/lib/slc6_amd64_gcc493/libSimCalorimetryHcalTrigPrimAlgos.so
#8 0x00007f24c3c4e144 in HcalTriggerPrimitiveAlgo::run(HcalTPGCoder const_, HcalTPGCompressor const_, edm::SortedCollection<HBHEDataFrame, edm::StrictWeakOrdering > const&, edm::SortedCollection<HFDataFrame, edm::StrictWeakOrdering > const&, edm::SortedCollection<HcalTriggerPrimitiveDigi, edm::StrictWeakOrdering >&, HcalTrigTowerGeometry const_, float, HcalFeatureBit const_) () from /cvmfs/cms-ib.cern.ch/2016-10/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-28-0000/lib/slc6_amd64_gcc493/libSimCalorimetryHcalTrigPrimAlgos.so
#9 0x00007f24c366c8a2 in HcalTrigPrimDigiProducer::produce(edm::Event&, edm::EventSetup const&) () from /cvmfs/cms-ib.cern.ch/2016-10/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-28-0000/lib/slc6_amd64_gcc493/pluginSimCalorimetryHcalTrigPrimProducers.so
#10 0x00007f2512bdd9c8 in edm::EDProducer::doEvent(edm::EventPrincipal const&, edm::EventSetup const&, edm::ActivityRegistry_, edm::ModuleCallingContext const_) () from /cvmfs/cms-ib.cern.ch/2016-10/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-28-0000/lib/slc6_amd64_gcc493/libFWCoreFramework.so
#11 0x00007f2512ccd69f in edm::WorkerTedm::EDProducer::implDo(edm::EventPrincipal const&, edm::EventSetup const&, edm::ModuleCallingContext const_) () from /cvmfs/cms-ib.cern.ch/2016-10/slc6_amd64_gcc493/cms/cmssw/CMSSW_8_0_X_2016-02-28-0000/lib/slc6_amd64_gcc493/libFWCoreFramework.so

mmusich · 2016-03-03T15:52:22Z

@davidlange6 thanks, shall we wait tonight for re-launching the tests?

franzoni · 2016-03-03T22:56:47Z

please test

cmsbuild · 2016-03-03T22:57:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11703/console

cmsbuild · 2016-03-04T03:09:37Z

-1
Tested at: ab7cdfc
When I ran the RelVals I found an error in the following worklfows:
140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

134.911 step3

runTheMatrix-results/134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT/step3_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13581/11703/summary.html

davidlange6 · 2016-03-04T06:04:09Z

seems i was wrong. @kpedro88 @ianna @bsunanda, please help

davidlange6 · 2016-03-04T06:54:16Z

ah - seems related to #13252 which was just fixed yesterday:(

cmsbuild · 2016-03-04T10:18:17Z

Pull request #13581 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please check and sign again.

mmusich · 2016-03-04T10:19:56Z

please test

cmsbuild · 2016-03-04T10:20:15Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11709/console

abdoulline · 2016-03-04T10:48:49Z

(sorry for non-instant answer, I've been at a working meeting)

Passing MC tests shouldn't be related to GEN-SIM version.
I presume MC is using right "extended" HcalLutMetadata tag HcalLutMetadata _v4.00_mc, so it works both for Run1 and Run 2 /2016 MC.

For data HcalLutMetadata _v1.01_hlt missed 1x1 HF TPs part (which is invoked by 2016 Geometry) up until IOV 263798...

On Fri, 4 Mar 2016, David Lange wrote:

I do not think the pr tests redo gen-sim in all workflows. I can run a small test to be sure

On Mar 4, 2016, at 10:40 AM, Marco Musich notifications@github.com wrote:

For MC my understanding is that this work because GEN-SIM are re-done in the PR test, right? What happens when
they are recycled from previous releases?

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub.[AEx02pXFCf4PnUmZFrjNRVGXCHFPW15mks5pp_9ZgaJpZM4HoX-w.gif]

mmusich · 2016-03-04T10:49:10Z

locally passing the tests:

4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Mar  4 11:23:44 2016-date Fri Mar  4 11:18:17 2016; exit: 0 0 0 0 0
5.1_TTbar+TTbarFS+HARVESTFS Step0-PASSED Step1-PASSED  - time date Fri Mar  4 11:23:06 2016-date Fri Mar  4 11:18:18 2016; exit: 0 0
8.0_BeamHalo+BeamHaloINPUT+DIGICOS+RECOCOS+ALCABH+HARVESTCOS Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Mar  4 11:25:06 2016-date Fri Mar  4 11:18:21 2016; exit: 0 0 0 0 0
25.0_TTbar+TTbarINPUT+DIGI+RECOAlCaCalo+HARVEST+ALCATT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Mar  4 11:33:00 2016-date Fri Mar  4 11:18:26 2016; exit: 0 0 0 0 0
134.911_RunSinglePh2015D+RunSinglePh2015D+HLTDR2_25ns+RECODR2_25nsreHLT+HARVESTDR2_25nsreHLT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Fri Mar  4 11:42:27 2016-date Fri Mar  4 11:23:09 2016; exit: 0 0 0 0
135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS Step0-PASSED Step1-PASSED Step2-PASSED  - time date Fri Mar  4 11:35:38 2016-date Fri Mar  4 11:23:52 2016; exit: 0 0 0
140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI Step0-PASSED Step1-PASSED Step2-PASSED  - time date Fri Mar  4 11:34:14 2016-date Fri Mar  4 11:25:13 2016; exit: 0 0 0
1330.0_ZMM_13+ZMM_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED  - time date Fri Mar  4 11:43:19 2016-date Fri Mar  4 11:33:05 2016; exit: 0 0 0 0
1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED  - time date Fri Mar  4 11:45:51 2016-date Fri Mar  4 11:34:20 2016; exit: 0 0 0 0 0
1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED Step5-PASSED Step6-PASSED  - time date Fri Mar  4 11:46:56 2016-date Fri Mar  4 11:35:40 2016; exit: 0 0 0 0 0 0 0
10 10 9 7 5 1 1 tests passed, 0 0 0 0 0 0 0 failed

mmusich · 2016-03-04T10:50:00Z

@abdoulline I confirm all MC workflows use the HcalLutMetadata _v4.00_mc tag.

cmsbuild · 2016-03-04T12:51:11Z

+1
Tested at: e6a43f9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13581/11708/summary.html

cmsbuild · 2016-03-04T13:22:56Z

+1
Tested at: 30a92fa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13581/11709/summary.html

abdoulline · 2016-03-04T13:52:01Z

Thank you for prompt (issue-resolving) action, Marco.

cmsbuild · 2016-03-04T13:57:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13581/11708/summary.html

Adding 1x1 HF trigger primitives in Hcal Geometry tags

davidlange6 · 2016-03-04T13:59:18Z

looks like the comparisons show no changes as expected.

mmusich · 2016-03-04T13:59:38Z

+1
for the record

cmsbuild · 2016-03-04T13:59:54Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

cmsbuild · 2016-03-04T14:55:11Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13581/11709/summary.html

cmsbuild added this to the Next CMSSW_8_0_X milestone Mar 3, 2016

cmsbuild added alca-pending pending-signatures tests-pending orp-pending comparison-pending labels Mar 3, 2016

Adding 1x1 HF trigger primitives in Hcal Geometry

ab7cdfc

mmusich force-pushed the GTs_80X_HF1x1 branch from 14f26fb to ab7cdfc Compare March 3, 2016 12:30

cmsbuild added tests-started and removed tests-pending labels Mar 3, 2016

cmsbuild added tests-rejected and removed tests-started labels Mar 3, 2016

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Mar 3, 2016

cmsbuild added tests-rejected and removed tests-started labels Mar 4, 2016

Adding IOVs for HcalParameters tag in the Data GTs

30a92fa

mmusich force-pushed the GTs_80X_HF1x1 branch from e6a43f9 to 30a92fa Compare March 4, 2016 10:17

cmsbuild added tests-pending and removed tests-started labels Mar 4, 2016

cmsbuild added tests-started and removed tests-pending labels Mar 4, 2016

cmsbuild added tests-approved and removed tests-started labels Mar 4, 2016

cmsbuild added comparison-available and removed comparison-pending labels Mar 4, 2016

davidlange6 added a commit that referenced this pull request Mar 4, 2016

Merge pull request #13581 from mmusich/GTs_80X_HF1x1

02f36fb

Adding 1x1 HF trigger primitives in Hcal Geometry tags

davidlange6 merged commit 02f36fb into cms-sw:CMSSW_8_0_X Mar 4, 2016

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Mar 4, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding 1x1 HF trigger primitives in Hcal Geometry tags #13581

Adding 1x1 HF trigger primitives in Hcal Geometry tags #13581

mmusich commented Mar 3, 2016

cmsbuild commented Mar 3, 2016

mmusich commented Mar 3, 2016

cmsbuild commented Mar 3, 2016

mmusich commented Mar 3, 2016

cmsbuild commented Mar 3, 2016

davidlange6 commented Mar 3, 2016

mmusich commented Mar 3, 2016

franzoni commented Mar 3, 2016

cmsbuild commented Mar 3, 2016

cmsbuild commented Mar 4, 2016

davidlange6 commented Mar 4, 2016

davidlange6 commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

mmusich commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

abdoulline commented Mar 4, 2016

mmusich commented Mar 4, 2016

mmusich commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

abdoulline commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

davidlange6 commented Mar 4, 2016

mmusich commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

Adding 1x1 HF trigger primitives in Hcal Geometry tags #13581

Adding 1x1 HF trigger primitives in Hcal Geometry tags #13581

Conversation

mmusich commented Mar 3, 2016

Summary of changes in Global Tags

RunII simulation

RunII data

cmsbuild commented Mar 3, 2016

mmusich commented Mar 3, 2016

cmsbuild commented Mar 3, 2016

mmusich commented Mar 3, 2016

cmsbuild commented Mar 3, 2016

davidlange6 commented Mar 3, 2016

mmusich commented Mar 3, 2016

franzoni commented Mar 3, 2016

cmsbuild commented Mar 3, 2016

cmsbuild commented Mar 4, 2016

davidlange6 commented Mar 4, 2016

davidlange6 commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

mmusich commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

abdoulline commented Mar 4, 2016

mmusich commented Mar 4, 2016

mmusich commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

abdoulline commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

davidlange6 commented Mar 4, 2016

mmusich commented Mar 4, 2016

cmsbuild commented Mar 4, 2016

cmsbuild commented Mar 4, 2016