Extend Calo objects to record intermediate steps in calculation #13584
Conversation
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @mulhearn for CMSSW_8_0_X. It involves the following packages: DataFormats/L1Trigger @cmsbuild, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
Nope: this version breaks emulation... need to add back constructor from L1Candidate. |
mulhearn
force-pushed
the
pr-caloobject-extension
branch
from
c334979
to
5a4b09c
Compare
|
Pull request #13584 was updated. @cmsbuild, @mulhearn, @davidlange6 can you please check and sign again. |
|
please test |
|
The tests are being triggered in jenkins. |
|
This past my own tests. |
|
+1 |
cmsbuild
added
l1-approved
fully-signed
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_0_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
|
@davidlange6 this one is intended for 801 if possible... it has DataFormat changes we'd like to lock in now. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Extend Calo objects to record intermediate steps in calculation
Adds (not yet exercised) variables to L1 calo output objects, which will allow for future recording of intermediate HW values during the calculation of each object.