Remove 2017 fake conditions #13601
Merged
Remove 2017 fake conditions #13601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not needed anymore, and the BeamSpot override becomes (is) wrong with a non-Gaussian BeamSpot in GlobalTag.
|
A new Pull Request was created by @makortel (Matti Kortelainen) for CMSSW_8_1_X. It involves the following packages: SLHCUpgradeSimulations/Configuration @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
@cmsbuild, please test |
|
The tests are being triggered in jenkins. |
davidlange6
added a commit
that referenced
this pull request
Mar 7, 2016
Remove 2017 fake conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes override of BeamSpot to Gaussian in 2017 customization. The BeamSpot should be taken from GlobalTag, especially after it gets/got updated from Gaussian to "run2 realistic" (in PRs #13516 (80X)/#13524 (81X)). This override caused the failure of 800patch1 2017 RelVals (see https://hypernews.cern.ch/HyperNews/CMS/get/relval/4545/1.html). There the "run2 realistic" BeamSpot was used consistently in SIM and GlobalTag, but was overridden to Gaussian for reco here. The other fake condition overrides are also unnecessary and thus removed.
Tested in CMSSW_8_1_X_2016-03-03-1100, no changes expected in IBs without #13516/#13524 (in IBs with either PR, large changes in tracking are expected).
@rovere @VinInn @boudoul