Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up for GCC 6 (<cmath> header, std::, __afs cache files) #13631

Merged
merged 3 commits into from Mar 8, 2016
Merged

Clean up for GCC 6 (<cmath> header, std::, __afs cache files) #13631

merged 3 commits into from Mar 8, 2016

Conversation

davidlt
Copy link
Contributor

@davidlt davidlt commented Mar 7, 2016

Misc. changes needed for GCC 6, but they are all general clean up.

David Abdurachmanov added 3 commits March 7, 2016 18:40
Remove .__afs.* files
e792b97 
These files could be related to AFS caching or similar. These should not
be part of repository.

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Add missing <cmath> header or/and std::
5cd610a 
The following errors are reported by GCC (6.0.0, r233941):

    L1Trigger/L1TMuonOverlap/src/OMTFSorter.cc:162:38: error: call of overloaded 'abs(float)' is ambiguous

    L1Trigger/L1TMuonBarrel/src/Twinmux_v1/PrimitiveCombiner.h:83:78: error: call of overloaded 'abs(float)' is ambiguous

    EventFilter/L1TRawToDigi/src/Unpacker.cc:14:28: error: 'floor' was not declared in this scope

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Do not check if address is 0/NULL/nullptr
ff3d04c 
The compiler (GCC and Clang) will report that comparing address of an
object to 0/NULL/nullptr will always be false. The address is not
the same as pointer.

The following errors are reported by GCC (6.0.0, r233941):

    L1Trigger/GlobalCaloTrigger/plugins/L1GctEmulator.cc:130:9: error: the compiler can assume that the address of 'c' will never be NULL [-Werror=address]
    L1Trigger/GlobalCaloTrigger/plugins/L1GctPrintLuts.cc:159:9: error: the compiler can assume that the address of 'c' will never be NULL [-Werror=address]
    L1Trigger/GlobalCaloTrigger/test/gctTestFunctions.cc:55:12: error: the compiler can assume that the address of 'c' will never be NULL [-Werror=address]
    L1Trigger/GlobalCaloTrigger/test/L1GctTest.cc:207:12: error: the compiler can assume that the address of 'c' will never be NULL [-Werror=address]
    L1Trigger/L1TGlobal/src/L1TMenuEditor/xsd/cxx/tree/elements.hxx:380:21: error: the compiler can assume that the address of 'x' will never be NULL [-Werror=address]

Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
@cmsbuild cmsbuild added this to the Next CMSSW_8_1_X milestone Mar 7, 2016
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

A new Pull Request was created by @davidlt for CMSSW_8_1_X.

It involves the following packages:

EventFilter/L1TRawToDigi
L1Trigger/GlobalCaloTrigger
L1Trigger/L1TGlobal
L1Trigger/L1TMuonBarrel
L1Trigger/L1TMuonOverlap

The following packages do not have a category, yet:

L1Trigger/L1TMuonBarrel
L1Trigger/L1TMuonOverlap

@cmsbuild, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@davidlt
Copy link
Contributor Author

davidlt commented Mar 7, 2016

Tests are scheduled.

@davidlt
Copy link
Contributor Author

davidlt commented Mar 7, 2016

@davidlange6 @smuzaffar we have two packages which are not assigned to any categories, I guess, these are L1 packages?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

+1
Tested at: ff3d04c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13631/11761/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2016

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13631/11761/summary.html

@smuzaffar
Copy link
Contributor

@davidlt, cms-bot has been updated. It should now recognize these packages as l1

davidlange6 added a commit that referenced this pull request Mar 8, 2016
@davidlange6
Merge pull request #13631 from davidlt/gcc600-l1-misc
dee7bbc 
Clean up for GCC 6 (<cmath> header, std::, __afs cache files)
@davidlange6 davidlange6 merged commit dee7bbc into cms-sw:CMSSW_8_1_X Mar 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
Next CMSSW_8_1_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidlt @cmsbuild @smuzaffar @davidlange6