Clean up ElectroWeakAnalysis (GCC 6) #13632
Conversation
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
Compilers can always assume that comparing reference to 0/NULL/nullptr
is always false. Reference is not a pointer. I believe, instead author
wanted to check if there are any items in the collection.
The following errors are reported by GCC (6.0.0, r233941):
ElectroWeakAnalysis/ZMuMu/plugins/MuTriggerAnalyzer.cc:184:12: error: the compiler can assume that the address of 'toc' will never be NULL [-Werror=address]
ElectroWeakAnalysis/ZMuMu/plugins/ZGoldenFilter.cc:116:15: error: the compiler can assume that the address of 'toc' will never be NULL [-Werror=address]
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_8_1_X. It involves the following packages: ElectroWeakAnalysis/Utilities @cmsbuild, @vadler, @davidlange6, @monttj can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
|
Tests are triggered. |
Clean up ElectroWeakAnalysis (GCC 6)
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Look for more details in commit messages. The changes are general and not specific to GCC (or it's version) in any way.