New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declare 'seedOnlyFromAbove_' as 'int' (Backport of #13643). #13646
Declare 'seedOnlyFromAbove_' as 'int' (Backport of #13643). #13646
Conversation
This member variable of the AlignmentTrackSelector was wrongly declared as boolean, causing the gcc 5.3.0 to complain about a comparison which can never be true.
A new Pull Request was created by @ghellwig (Gregor Mittag) for CMSSW_7_6_X. It involves the following packages: Alignment/CommonAlignmentProducer @diguida, @cerminar, @cmsbuild, @franzoni, @mmusich, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
+1 |
This member variable of the AlignmentTrackSelector was wrongly declared as
boolean, causing the gcc 5.3.0 to complain about a comparison which can never be
true.
Fixes issue #13578
Backport of #13643