TagInfo collection name update

[ferencek]

PAT jets store TagInfo names by stripping everything starting from 'TagInfos'. Hence, internally it is not possible to distinguish pfImpactParameterTagInfosAK8 from pfImpactParameterTagInfos. So to avoid possible ambiguities, TagInfo collection names need to end with 'TagInfos'.

This PR does not change MiniAOD in 76X and it also does not have any impact on reading older 76X MiniAOD files.

Backport of a single commit from #13685.

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko Ferenček) for CMSSW_7_6_X.

It involves the following packages:

PhysicsTools/PatAlgos
RecoBTag/ImpactParameter
RecoBTag/SecondaryVertex

@cvuosalo, @monttj, @cmsbuild, @slava77, @vadler, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @imarches, @ahinzmann, @acaudron, @mmarionncern, @rappoccio, @jdolen, @nhanvtran, @schoef, @ferencek, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

[cvuosalo]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/11851/console

[cmsbuild]

+1
Tested at: 056c7db
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13700/11851/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-13700/11851/summary.html

[cvuosalo]

+1

For #13700 056c7db

Renaming TagInfos collections to avoid confusion.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2016-03-08-2300 show no significant differences. An extended test of workflow 25202.0_TTbar_13 with 70 events against baseline CMSSW_7_6_4 also shows no significant differences, no change in RECO or Mini-AOD event content, and no significant change in CPU time or memory usage. The renaming's only effect is that two modules run with new names but take the same amount of CPU time:

  delta/mean delta/orJob     original                   new       module name
  ---------- ------------     --------                  ----       ------------
     removed      -0.00%         0.34 ms/ev ->         0.00 ms/ev pfInclusiveSecondaryVertexFinderTagInfosAK8AK8
       added      +0.00%         0.00 ms/ev ->         0.33 ms/ev pfInclusiveSecondaryVertexFinderAK8TagInfosAK8
     removed      -0.00%         2.10 ms/ev ->         0.00 ms/ev pfImpactParameterTagInfosAK8AK8
       added      +0.00%         0.00 ms/ev ->         2.11 ms/ev pfImpactParameterAK8TagInfosAK8

[slava77]

       added      +0.00%         0.00 ms/ev ->         0.33 ms/ev pfInclusiveSecondaryVertexFinderAK8TagInfosAK8

This is strange. I thought the goal was to have "TagInfos" at the end of the name. Did the addJetCollection postfix add it anyways
@ferencek please clarify

[ferencek]

@slava77, yes, addJetCollection adds a user-defined label (in the above case AK8) at the end of the module name. However, what matters for adding TagInfos to PAT jets is the string up to "TagInfos" (see https://github.com/cms-sw/cmssw/blob/CMSSW_7_6_4/DataFormats/PatCandidates/src/Jet.cc#L406-L416). So to be able to distinguish pfImpactParameterTagInfosAK8 from pfImpactParameterTagInfos among the added TagInfos, it is necessary to move AK8 in front of TagInfos. Additional AK8, which could be any other string, at the end of the name in the above example is not relevant and is dropped from the internally stored TagInfo name.