Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron validation 80X histo name modification #13726

Merged
merged 3 commits into from Apr 6, 2016
Merged

Electron validation 80X histo name modification #13726

merged 3 commits into from Apr 6, 2016

Conversation

archiron
Copy link
Contributor

An histo name modification was made in files ElectronMcSignalPostValidator.cc (lines 70-71) and ElectronMcSignalValidator.cc (line 768). Title and legend axis were modified.

A small modification about miniAOD cut over 5Gev is removed (lines 1429 & 1431) in the ElectronMcSignalValidator.cc file.

Small modification are made in the electronCompare.C file (lines 428 to 450) in order to take correctly into account miniAOD vs RECO in the web page validation.

Tests about PR are made and passed :
PR_batch-20160315.txt

@beaudett @matteosan1 @fcouderc

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @archiron (Chiron) for CMSSW_8_1_X.

It involves the following packages:

Validation/RecoEgamma

@cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks.
@richard-cms this is something you requested to watch as well.
@slava77, @Degano, @smuzaffar you are the release manager for this.

cms-bot commands are list here #13028

@deguio
Copy link
Contributor

deguio commented Mar 22, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/12004/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Apr 5, 2016

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2016

This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar

@davidlange6 davidlange6 merged commit cdacfc0 into cms-sw:CMSSW_8_1_X Apr 6, 2016
@archiron archiron deleted the ElectronValidation_80X_HistoName branch July 19, 2019 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants