New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electron validation 80X histo name modification #13726
Electron validation 80X histo name modification #13726
Conversation
A new Pull Request was created by @archiron (Chiron) for CMSSW_8_1_X. It involves the following packages: Validation/RecoEgamma @cmsbuild, @vanbesien, @deguio, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are list here #13028 |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_8_1_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @slava77, @davidlange6, @Degano, @smuzaffar |
An histo name modification was made in files ElectronMcSignalPostValidator.cc (lines 70-71) and ElectronMcSignalValidator.cc (line 768). Title and legend axis were modified.
A small modification about miniAOD cut over 5Gev is removed (lines 1429 & 1431) in the ElectronMcSignalValidator.cc file.
Small modification are made in the electronCompare.C file (lines 428 to 450) in order to take correctly into account miniAOD vs RECO in the web page validation.
Tests about PR are made and passed :
PR_batch-20160315.txt
@beaudett @matteosan1 @fcouderc